Issue 6652002: Make sure the GAE SDK don't look for SDK updates while running presubmit checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6652002: Make sure the GAE SDK don't look for SDK updates while running presubmit checks (Closed)

Created:
9 years, 9 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Bernhard Bauer, Evan Martin

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Make sure the GAE SDK don't look for SDK updates while running presubmit checks Otherwise the local Rietveld instance could mysteriously hang. TEST=presubmit check won't fail even if an old version of the SDK is used BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79338

Patch Set 1 #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	git_cl/test/local_rietveld.py	View		1 chunk	+9 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/6652002/diff/1/git_cl/test/local_rietveld.py File git_cl/test/local_rietveld.py (right): http://codereview.chromium.org/6652002/diff/1/git_cl/test/local_rietveld.py#newcode108 git_cl/test/local_rietveld.py:108: '.', What is this arg?

9 years, 9 months ago (2011-03-08 21:31:51 UTC) #2

Bernhard Bauer

I guess it's the rietveld directory (which is the working directory for the command)? LGTM. ...

9 years, 9 months ago (2011-03-08 21:43:13 UTC) #3

M-A Ruel

9 years, 9 months ago (2011-03-08 22:36:27 UTC) #4

http://codereview.chromium.org/6652002/diff/1/git_cl/test/local_rietveld.py
File git_cl/test/local_rietveld.py (right):

http://codereview.chromium.org/6652002/diff/1/git_cl/test/local_rietveld.py#n...
git_cl/test/local_rietveld.py:108: '.',
On 2011/03/08 21:31:51, Evan Martin wrote:
> What is this arg?

Bernhard is right, it's the current directory.

Expand Messages | Collapse Messages