 Chromium Code Reviews
 Chromium Code Reviews Issue 6652002:
  Make sure the GAE SDK don't look for SDK updates while running presubmit checks  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
    
  
    Issue 6652002:
  Make sure the GAE SDK don't look for SDK updates while running presubmit checks  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools| Index: git_cl/test/local_rietveld.py | 
| diff --git a/git_cl/test/local_rietveld.py b/git_cl/test/local_rietveld.py | 
| index 95e27b60b3bac41052abc90a99a90ac47df97b3e..88b2c302d211a6180a1758046ea915b3cf31fd02 100644 | 
| --- a/git_cl/test/local_rietveld.py | 
| +++ b/git_cl/test/local_rietveld.py | 
| @@ -102,10 +102,16 @@ class LocalRietveld(object): | 
| stdout = subprocess.PIPE | 
| stderr = subprocess.PIPE | 
| output = [] | 
| + cmd = [ | 
| + self.dev_app, | 
| + '--skip_sdk_update_check', | 
| + '.', | 
| 
Evan Martin
2011/03/08 21:31:51
What is this arg?
 
M-A Ruel
2011/03/08 22:36:28
Bernhard is right, it's the current directory.
 | 
| + '--port=%d' % self.port, | 
| + '--datastore_path=' + os.path.join(self.rietveld, 'tmp.db'), | 
| + '-c'] | 
| self.test_server = subprocess.Popen( | 
| - [self.dev_app, self.rietveld, '--port=%d' % self.port, | 
| - '--datastore_path=' + os.path.join(self.rietveld, 'tmp.db'), '-c'], | 
| - stdout=stdout, stderr=stderr, env=self.env) | 
| + cmd, stdout=stdout, stderr=stderr, env=self.env, | 
| + cwd=self.rietveld) | 
| # Loop until port 127.0.0.1:port opens or the process dies. | 
| while not test_port(self.port): | 
| self.test_server.poll() |