Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: git_cl/test/local_rietveld.py

Issue 6652002: Make sure the GAE SDK don't look for SDK updates while running presubmit checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl/test/local_rietveld.py
diff --git a/git_cl/test/local_rietveld.py b/git_cl/test/local_rietveld.py
index 95e27b60b3bac41052abc90a99a90ac47df97b3e..88b2c302d211a6180a1758046ea915b3cf31fd02 100644
--- a/git_cl/test/local_rietveld.py
+++ b/git_cl/test/local_rietveld.py
@@ -102,10 +102,16 @@ class LocalRietveld(object):
stdout = subprocess.PIPE
stderr = subprocess.PIPE
output = []
+ cmd = [
+ self.dev_app,
+ '--skip_sdk_update_check',
+ '.',
Evan Martin 2011/03/08 21:31:51 What is this arg?
M-A Ruel 2011/03/08 22:36:28 Bernhard is right, it's the current directory.
+ '--port=%d' % self.port,
+ '--datastore_path=' + os.path.join(self.rietveld, 'tmp.db'),
+ '-c']
self.test_server = subprocess.Popen(
- [self.dev_app, self.rietveld, '--port=%d' % self.port,
- '--datastore_path=' + os.path.join(self.rietveld, 'tmp.db'), '-c'],
- stdout=stdout, stderr=stderr, env=self.env)
+ cmd, stdout=stdout, stderr=stderr, env=self.env,
+ cwd=self.rietveld)
# Loop until port 127.0.0.1:port opens or the process dies.
while not test_port(self.port):
self.test_server.poll()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698