Issue 6648016: Changing icu to use gyp 'copies', rather than use a rules file....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6648016: Changing icu to use gyp 'copies', rather than use a rules file.... (Closed)

Created:
9 years, 9 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
jeanluc, jeanluc1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/

Visibility:
Public.

Description

Changing icu to use gyp 'copies', rather than use a rules file. msbuild won't use the same rules files, so this blocks msbuild support. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78292

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	icu.gyp	View		2 chunks	+8 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jeanluc1

LGTM http://codereview.chromium.org/6648016/diff/1/icu.gyp File icu.gyp (left): http://codereview.chromium.org/6648016/diff/1/icu.gyp#oldcode53 icu.gyp:53: 'msvs_tool_files': ['../../build/output_dll_copy.rules'], Should we delete the output_dll_copy.rules file ...

9 years, 9 months ago (2011-03-09 01:30:59 UTC) #2

bradn

9 years, 9 months ago (2011-03-09 02:01:24 UTC) #3

I will, but its in a separate repo, so it needs to be a separate CL.
I'll do that with the DEPS roll to pull this in.

On Tue, Mar 8, 2011 at 5:31 PM, <jeanluc@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/6648016/diff/1/icu.gyp
> File icu.gyp (left):
>
> http://codereview.chromium.org/6648016/diff/1/icu.gyp#oldcode53
> icu.gyp:53: 'msvs_tool_files': ['../../build/output_dll_copy.rules'],
> Should we delete the output_dll_copy.rules file too?
>
>
> http://codereview.chromium.org/6648016/
>

Expand Messages | Collapse Messages