Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: icu.gyp

Issue 6648016: Changing icu to use gyp 'copies', rather than use a rules file.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu.gyp
===================================================================
--- icu.gyp (revision 75916)
+++ icu.gyp (working copy)
@@ -35,7 +35,6 @@
'target_name': 'icudata',
'type': '<(library)',
'sources': [
- 'windows/icudt46.dll',
# These are hand-generated, but will do for now. The linux
# version is an identical copy of the (mac) icudt46l_dat.S file,
# modulo removal of the .private_extern and .const directives and
@@ -50,9 +49,14 @@
'conditions': [
[ 'OS == "win"', {
'type': 'none',
- 'msvs_tool_files': ['../../build/output_dll_copy.rules'],
jeanluc1 2011/03/09 01:31:00 Should we delete the output_dll_copy.rules file to
- }, { # else: OS != "win"
- 'sources!': ['windows/icudt46.dll'],
+ 'copies': [
+ {
+ 'destination': '<(PRODUCT_DIR)',
+ 'files': [
+ 'windows/icudt46.dll',
+ ],
+ },
+ ],
}],
[ 'OS != "linux" or chromeos == 1', {
'sources!': ['linux/icudt46l_dat.S'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698