Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: chrome/browser/chromeos/cros/update_library.h

Issue 6648009: Modify UpdateLibrary to use async RequestUpdateCheck call (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/update_library.h
diff --git a/chrome/browser/chromeos/cros/update_library.h b/chrome/browser/chromeos/cros/update_library.h
index 0ad23c03c06e9394875825b12ab5d68efe4eaee0..c976afb97e9766c9e458f3b9d9a97c4057889db9 100644
--- a/chrome/browser/chromeos/cros/update_library.h
+++ b/chrome/browser/chromeos/cros/update_library.h
@@ -63,7 +63,11 @@ class UpdateLibrary {
virtual void RemoveObserver(Observer* observer) = 0;
// Initiates update check and returns true if check was initiated.
- virtual bool CheckForUpdate() = 0;
+ virtual void CheckForUpdate() = 0;
altimofeev 2011/03/09 10:42:27 Please, fix the comment. Also, consider deprecatin
stevenjb 2011/03/10 01:23:16 Removed.
+
+ // Request an update check and call |callback| when the request has completed.
+ virtual void RequestUpdate(chromeos::UpdateCallback callback,
altimofeev 2011/03/09 10:42:27 Why don't use RequestUpdateCheck for the consisten
stevenjb 2011/03/10 01:23:16 Sure. Done.
+ void* user_data) = 0;
// Reboots if update has been performed.
virtual bool RebootAfterUpdate() = 0;

Powered by Google App Engine
This is Rietveld 408576698