Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: chrome/browser/chromeos/cros/update_library.cc

Issue 6648009: Modify UpdateLibrary to use async RequestUpdateCheck call (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/update_library.cc
diff --git a/chrome/browser/chromeos/cros/update_library.cc b/chrome/browser/chromeos/cros/update_library.cc
index 80a4b96734452686530e2768afe4d5be47c5f006..e7992b18943b8a58f288a4b95d131760cd415b6f 100644
--- a/chrome/browser/chromeos/cros/update_library.cc
+++ b/chrome/browser/chromeos/cros/update_library.cc
@@ -36,11 +36,14 @@ class UpdateLibraryImpl : public UpdateLibrary {
observers_.RemoveObserver(observer);
}
- bool CheckForUpdate() {
- if (!CrosLibrary::Get()->EnsureLoaded())
- return false;
+ void CheckForUpdate() {
+ if (CrosLibrary::Get()->EnsureLoaded())
+ RequestUpdateCheck(NULL, NULL);
+ }
- return InitiateUpdateCheck();
+ void RequestUpdate(chromeos::UpdateCallback callback, void* user_data) {
+ if (CrosLibrary::Get()->EnsureLoaded())
+ RequestUpdateCheck(callback, user_data);
}
bool RebootAfterUpdate() {
@@ -119,7 +122,11 @@ class UpdateLibraryStubImpl : public UpdateLibrary {
~UpdateLibraryStubImpl() {}
void AddObserver(Observer* observer) {}
void RemoveObserver(Observer* observer) {}
- bool CheckForUpdate() { return false; }
+ void CheckForUpdate() {}
+ void RequestUpdate(chromeos::UpdateCallback callback, void* user_data) {
+ if (callback)
+ callback(user_data, UPDATE_RESULT_FAILED, "stub update");
+ }
bool RebootAfterUpdate() { return false; }
bool SetReleaseTrack(const std::string& track) { return false; }
std::string GetReleaseTrack() { return "beta-channel"; }

Powered by Google App Engine
This is Rietveld 408576698