chrome/browser/automation/testing_automation_provider.cc - Issue 6635032: Removing references to off the record in comments and log messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 6635032: Removing references to off the record in comments and log messages. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Updating the AUTHORS file. Patch submitted by: Vipul Bhasin<vipul.bhasin@gmail.com> Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/search_provider.cc ('K') | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/background_contents_service.h » ('j') | chrome/browser/chromeos/login/login_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/testing_automation_provider.cc

diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc

index e36d655199dae216bf32dda9ae976ba35daef9a8..fffcb1077262e76efd4d034e5eaab7afbe401330 100644

--- a/chrome/browser/automation/testing_automation_provider.cc

+++ b/chrome/browser/automation/testing_automation_provider.cc

@@ -3435,7 +3435,7 @@ void TestingAutomationProvider::AddSavedPassword(

GetPasswordFormFromDict(*password_dict);

Profile* profile = browser->profile();

- // Use IMPLICIT_ACCESS since new passwords aren't added off the record.

+ // Use IMPLICIT_ACCESS since new passwords aren't added incognito.

akalin 2011/03/08 03:07:47 this becomes awkward phrasing; maybe "added in inc

PasswordStore* password_store =

profile->GetPasswordStore(Profile::IMPLICIT_ACCESS);

@@ -3478,7 +3478,7 @@ void TestingAutomationProvider::RemoveSavedPassword(

GetPasswordFormFromDict(*password_dict);

Profile* profile = browser->profile();

- // Use EXPLICIT_ACCESS since passwords can be removed off the record.

+ // Use EXPLICIT_ACCESS since passwords can be removed incognito.

akalin 2011/03/08 03:07:47 here, too

PasswordStore* password_store =

profile->GetPasswordStore(Profile::EXPLICIT_ACCESS);

@@ -3494,7 +3494,7 @@ void TestingAutomationProvider::GetSavedPasswords(

DictionaryValue* args,

IPC::Message* reply_message) {

Profile* profile = browser->profile();

- // Use EXPLICIT_ACCESS since saved passwords can be retreived off the record.

+ // Use EXPLICIT_ACCESS since saved passwords can be retreived incognito.

akalin 2011/03/08 03:07:47 here, too

PasswordStore* password_store =

profile->GetPasswordStore(Profile::EXPLICIT_ACCESS);

password_store->GetAutofillableLogins(