chrome/browser/autocomplete/search_provider.cc - Issue 6635032: Removing references to off the record in comments and log messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/search_provider.cc

Issue 6635032: Removing references to off the record in comments and log messages. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Updating the AUTHORS file. Patch submitted by: Vipul Bhasin<vipul.bhasin@gmail.com> Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/chrome_main_uitest.cc ('k') | chrome/browser/automation/automation_provider.cc » ('j') | chrome/browser/automation/testing_automation_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/search_provider.cc

diff --git a/chrome/browser/autocomplete/search_provider.cc b/chrome/browser/autocomplete/search_provider.cc

index ed308bb822b07ad77594140e325805c3cf6e37b7..d2e2787666b69a387e7717c0a0ebc353565c2945 100644

--- a/chrome/browser/autocomplete/search_provider.cc

+++ b/chrome/browser/autocomplete/search_provider.cc

@@ -349,7 +349,7 @@ void SearchProvider::StartOrStopSuggestQuery(bool minimal_changes) {

}

bool SearchProvider::IsQuerySuitableForSuggest() const {

- // Don't run Suggest when off the record, the engine doesn't support it, or

+ // Don't run Suggest when incognito, the engine doesn't support it, or

akalin 2011/03/08 03:07:47 maybe "when incognito" -> "in incognito mode"?

// the user has disabled it.

if (profile_->IsOffTheRecord() ||

(!providers_.valid_suggest_for_keyword_provider() &&