Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 6633001: Convert autofill messages to use the new IPC macros (Closed)

Created:
9 years, 9 months ago by Tom Sepez
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, Ilya Sherman, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, James Hawkins, dhollowa
Visibility:
Public.

Description

Convert autofill messages to use the new IPC macros. This requires changing the FormField class to a struct with publically-visible members, which was what should have been done in the first place, instead of the trivial setters/getters which are accessed in various combinations independently of each other throughout the code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77296

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -444 lines) Patch
M chrome/browser/autocomplete_history_manager.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/autofill/address_field.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_common_test.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_field.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_field_unittest.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 2 3 4 5 6 7 11 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/autofill/autofill_manager_unittest.cc View 1 2 3 4 5 6 7 10 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/autofill/autofill_merge_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 1 2 3 4 5 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autofill/credit_card_field.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/form_field.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/form_field_unittest.cc View 1 2 3 4 5 6 7 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/browser/autofill/form_structure.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager_unittest.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/phone_field.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/select_control_handler.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/select_control_handler.cc View 1 2 3 4 5 6 7 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/autofill/select_control_handler_unittest.cc View 1 2 3 4 5 6 7 8 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/webdata/web_database.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_database.cc View 1 2 3 4 5 6 7 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/autofill_messages.h View 1 2 3 4 5 6 7 2 chunks +29 lines, -38 lines 0 comments Download
D chrome/common/autofill_messages.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -105 lines 0 comments Download
M chrome/common/common_message_generator.h View 1 2 3 4 5 6 7 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/autofill_agent.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/autofill/form_manager.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/form_manager.cc View 1 2 3 4 5 6 7 11 chunks +17 lines, -17 lines 0 comments Download
M chrome/renderer/autofill/form_manager_browsertest.cc View 1 2 3 4 5 6 7 12 chunks +46 lines, -46 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_manager.cc View 1 2 3 4 5 6 7 6 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/form_field.h View 1 2 3 4 5 6 7 3 chunks +8 lines, -35 lines 0 comments Download
M webkit/glue/form_field.cc View 1 2 3 4 5 6 7 4 chunks +36 lines, -36 lines 0 comments Download
M webkit/glue/webpasswordautocompletelistener_impl.cc View 1 2 3 4 5 6 7 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Fire away.
9 years, 9 months ago (2011-03-04 22:55:53 UTC) #1
jam
lgtm
9 years, 9 months ago (2011-03-04 23:21:00 UTC) #2
Tom Sepez
9 years, 9 months ago (2011-03-08 18:16:17 UTC) #3
Reverted.  Chromeos broken.

Powered by Google App Engine
This is Rietveld 408576698