Convert autofill messages to use the new IPC macros

chrome/browser/autofill/autofill_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
 #include "base/scoped_vector.h"
 #include "base/string16.h"
@@ skipping 1160 matching lines @@
 // Test that we return autocomplete-like suggestions when trying to autofill
 // already filled forms.
 TEST_F(AutofillManagerTest, GetFieldSuggestionsWhenFormIsAutoFilled) {
   // Set up our form data.
   FormData form;
   CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Mark one of the fields as filled.
-  form.fields[2].set_autofilled(true);
+  form.fields[2].is_autofilled = true;
   const FormField& field = form.fields[0];
   GetAutoFillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<string16>());
 
   // Test that we sent the right message to the renderer.
   int page_id = 0;
   std::vector<string16> values;
@@ skipping 67 matching lines @@
   FormsSeen(forms);
 
   // |profile| will be owned by the mock PersonalDataManager.
   AutoFillProfile* profile = new AutoFillProfile;
   autofill_test::SetProfileInfo(profile, "Elvis", "", "", "", "",
                                 "", "", "", "", "", "", "", "");
   profile->set_guid("00000000-0000-0000-0000-000000000101");
   autofill_manager_->AddProfile(profile);
 
   FormField& field = form.fields[0];
-  field.set_autofilled(true);
+  field.is_autofilled = true;
   GetAutoFillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<string16>());
 
   // Test that we sent the right message to the renderer.
   int page_id = 0;
   std::vector<string16> values;
   std::vector<string16> labels;
@@ skipping 190 matching lines @@
 // Test that we correctly fill a form that has multiple logical sections, e.g.
 // both a billing and a shipping address.
 TEST_F(AutofillManagerTest, FillFormWithMultipleSections) {
   // Set up our form data.
   FormData form;
   CreateTestAddressFormData(&form);
   const size_t kAddressFormSize = form.fields.size();
   CreateTestAddressFormData(&form);
   for (size_t i = kAddressFormSize; i < form.fields.size(); ++i) {
     // Make sure the fields have distinct names.
-    form.fields[i].set_name(form.fields[i].name() + ASCIIToUTF16("_"));
+    form.fields[i].name = form.fields[i].name + ASCIIToUTF16("_");
   }
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Fill the first section.
   std::string guid = "00000000-0000-0000-0000-000000000001";
   FillAutoFillFormData(kDefaultPageID, form, form.fields[0],
                        autofill_manager_->PackGUIDs(std::string(), guid));
 
   int page_id = 0;
   FormData results;
   EXPECT_TRUE(GetAutoFillFormDataFilledMessage(&page_id, &results));
   {
     SCOPED_TRACE("Address 1");
 
     // The second address section should be empty.
     ASSERT_EQ(results.fields.size(), 2*kAddressFormSize);
     for (size_t i = kAddressFormSize; i < form.fields.size(); ++i) {
-      EXPECT_EQ(string16(), results.fields[i].value());
+      EXPECT_EQ(string16(), results.fields[i].value);
     }
 
     // The first address section should be filled with Elvis's data.
     results.fields.resize(kAddressFormSize);
     ExpectFilledAddressFormElvis(page_id, results, kDefaultPageID, false);
   }
 
   // Fill the second section, with the initiating field somewhere in the middle
   // of the section.
   const int kPageID2 = 2;
   guid = "00000000-0000-0000-0000-000000000001";
   ASSERT_LT(9U, kAddressFormSize);
   FillAutoFillFormData(kPageID2, form, form.fields[kAddressFormSize + 9],
                        autofill_manager_->PackGUIDs(std::string(), guid));
 
   page_id = 0;
   EXPECT_TRUE(GetAutoFillFormDataFilledMessage(&page_id, &results));
   {
     SCOPED_TRACE("Address 2");
     ASSERT_EQ(results.fields.size(), form.fields.size());
 
     // The first address section should be empty.
     ASSERT_EQ(results.fields.size(), 2*kAddressFormSize);
     for (size_t i = 0; i < kAddressFormSize; ++i) {
-      EXPECT_EQ(string16(), results.fields[i].value());
+      EXPECT_EQ(string16(), results.fields[i].value);
     }
 
     // The second address section should be filled with Elvis's data.
     FormData secondSection = results;
     secondSection.fields.erase(secondSection.fields.begin(),
                                secondSection.fields.begin() + kAddressFormSize);
     for (size_t i = 0; i < kAddressFormSize; ++i) {
       // Restore the expected field names.
-      string16 name = secondSection.fields[i].name();
+      string16 name = secondSection.fields[i].name;
       string16 original_name = name.substr(0, name.size() - 1);
-      secondSection.fields[i].set_name(original_name);
+      secondSection.fields[i].name = original_name;
     }
     ExpectFilledAddressFormElvis(page_id, secondSection, kPageID2, false);
   }
 }
 
 // Test that we correctly fill a previously auto-filled form.
 TEST_F(AutofillManagerTest, FillAutoFilledForm) {
   // Set up our form data.
   FormData form;
   CreateTestAddressFormData(&form);
   // Mark one of the address fields as autofilled.
-  form.fields[4].set_autofilled(true);
+  form.fields[4].is_autofilled = true;
   CreateTestCreditCardFormData(&form, true, false);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // First fill the address data.
   std::string guid = "00000000-0000-0000-0000-000000000001";
   FillAutoFillFormData(
       kDefaultPageID, form, *form.fields.begin(),
       autofill_manager_->PackGUIDs(std::string(), guid));
 
@@ skipping 19 matching lines @@
   {
     SCOPED_TRACE("Credit card 1");
     ExpectFilledCreditCardFormElvis(page_id, results, kPageID2, true);
   }
 
   // Now set the credit card fields to also be auto-filled, and try again to
   // fill the credit card data
   for (std::vector<FormField>::iterator iter = form.fields.begin();
        iter != form.fields.end();
        ++iter) {
-    iter->set_autofilled(true);
+    iter->is_autofilled = true;
   }
 
   const int kPageID3 = 3;
   FillAutoFillFormData(
       kPageID3, form, *form.fields.rbegin(),
       autofill_manager_->PackGUIDs(guid, std::string()));
 
   page_id = 0;
   EXPECT_TRUE(GetAutoFillFormDataFilledMessage(&page_id, &results));
   {
@@ skipping 10 matching lines @@
   FormData form;
   form.name = ASCIIToUTF16("MyPhoneForm");
   form.method = ASCIIToUTF16("POST");
   form.origin = GURL("http://myform.com/phone_form.html");
   form.action = GURL("http://myform.com/phone_submit.html");
   form.user_submitted = true;
 
   FormField field;
   autofill_test::CreateTestFormField(
       "country code", "country code", "", "text", &field);
-  field.set_max_length(1);
+  field.max_length = 1;
   form.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "area code", "area code", "", "text", &field);
-  field.set_max_length(3);
+  field.max_length = 3;
   form.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "phone", "phone prefix", "1", "text", &field);
-  field.set_max_length(3);
+  field.max_length = 3;
   form.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "-", "phone suffix", "", "text", &field);
-  field.set_max_length(4);
+  field.max_length = 4;
   form.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Phone Extension", "ext", "", "text", &field);
-  field.set_max_length(3);
+  field.max_length = 3;
   form.fields.push_back(field);
 
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   AutoFillProfile *work_profile = autofill_manager_->GetProfileWithGUID(
       "00000000-0000-0000-0000-000000000002");
   ASSERT_TRUE(work_profile != NULL);
   const AutofillType phone_type(PHONE_HOME_NUMBER);
   string16 saved_phone = work_profile->GetFieldText(phone_type);
 
   char test_data[] = "1234567890123456";
   for (int i = arraysize(test_data) - 1; i >= 0; --i) {
     test_data[i] = 0;
     SCOPED_TRACE(StringPrintf("Testing phone: %s", test_data));
     work_profile->SetInfo(phone_type, ASCIIToUTF16(test_data));
     // The page ID sent to the AutofillManager from the RenderView, used to send
     // an IPC message back to the renderer.
     int page_id = 100 - i;
     FillAutoFillFormData(
         page_id, form, *form.fields.begin(),
         autofill_manager_->PackGUIDs(std::string(), work_profile->guid()));
     page_id = 0;
     FormData results;
     EXPECT_TRUE(GetAutoFillFormDataFilledMessage(&page_id, &results));
 
     if (i != 7) {
-      EXPECT_EQ(ASCIIToUTF16(test_data), results.fields[2].value());
-      EXPECT_EQ(ASCIIToUTF16(test_data), results.fields[3].value());
+      EXPECT_EQ(ASCIIToUTF16(test_data), results.fields[2].value);
+      EXPECT_EQ(ASCIIToUTF16(test_data), results.fields[3].value);
     } else {
       // The only size that is parsed and split, right now is 7:
-      EXPECT_EQ(ASCIIToUTF16("123"), results.fields[2].value());
-      EXPECT_EQ(ASCIIToUTF16("4567"), results.fields[3].value());
+      EXPECT_EQ(ASCIIToUTF16("123"), results.fields[2].value);
+      EXPECT_EQ(ASCIIToUTF16("4567"), results.fields[3].value);
     }
   }
 
   work_profile->SetInfo(phone_type, saved_phone);
 }
 
 // Test that we can still fill a form when a field has been removed from it.
 TEST_F(AutofillManagerTest, FormChangesRemoveField) {
   // Set up our form data.
   FormData form;
@@ skipping 68 matching lines @@
 #else
   ASSERT_FALSE(profile()->GetPrefs()->GetBoolean(
       prefs::kAutoFillAuxiliaryProfilesEnabled));
   profile()->GetPrefs()->SetBoolean(
       prefs::kAutoFillAuxiliaryProfilesEnabled, true);
   profile()->GetPrefs()->ClearPref(prefs::kAutoFillAuxiliaryProfilesEnabled);
   ASSERT_FALSE(profile()->GetPrefs()->GetBoolean(
       prefs::kAutoFillAuxiliaryProfilesEnabled));
 #endif
 }