Allow webdriver users to choose between sending the key events when...

chrome/test/webdriver/chromedriver_tests.py

Index: chrome/test/webdriver/chromedriver_tests.py
===================================================================
--- chrome/test/webdriver/chromedriver_tests.py	(revision 76851)
+++ chrome/test/webdriver/chromedriver_tests.py	(working copy)
@@ -111,7 +111,7 @@
   def testCanStartChromeDriverOnSpecificPort(self):
     launcher = ChromeDriverLauncher(port=9520)
     self.assertEquals(9520, launcher.GetPort())
-    driver = WebDriver(launcher.GetURL(), 'chrome', 'any')
+    driver = WebDriver(launcher.GetURL(), {})

[kkania, 2011/03/10 00:28:58]

I think this will probably break the tests. The python bindings currently in
chromium tree expect 3 args, not 2. You can either modify src/DEPS to pull in a
newer version of the bindings (should be done in a different CL) or wait for
someone else to do it for you (probably we'll get to it this week or next)

[timothe faudot, 2011/03/10 05:34:32]

Yes this is the syntax for the 2.0b3 bindings, the previous bindings only allow
to specify some of the desiredCapabilities (browser, version) but not custom
ones like the one I am using "chrome.nativeEvents" hence my change to the
current version.
I am keener on letting someone do the update as I don't really know what other
parts of the tree are using the bindings now except chromedriver.

     driver.quit()
     launcher.Kill()
 
@@ -123,7 +123,7 @@
 
   def setUp(self):
     self._launcher = ChromeDriverLauncher()
-    self._driver = WebDriver(self._launcher.GetURL(), 'chrome', 'any')
+    self._driver = WebDriver(self._launcher.GetURL(), {})
 
   def tearDown(self):
     self._driver.quit()
@@ -174,7 +174,7 @@
     self.assertEquals(data['sessionId'], url_parts[2])
 
   def testShouldBeGivenCapabilitiesWhenStartingASession(self):
-    driver = WebDriver(self._launcher.GetURL(), 'chrome', 'any')
+    driver = WebDriver(self._launcher.GetURL(), {})
     capabilities = driver.capabilities
 
     self.assertEquals('chrome', capabilities['browserName'])
@@ -201,16 +201,16 @@
     driver.quit()
 
   def testSessionCreationDeletion(self):
-    driver = WebDriver(self._launcher.GetURL(), 'chrome', 'any')
+    driver = WebDriver(self._launcher.GetURL(), {})
     driver.quit()
 
   def testMultipleSessionCreationDeletion(self):
     for i in range(10):
-      driver = WebDriver(self._launcher.GetURL(), 'chrome', 'any')
+      driver = WebDriver(self._launcher.GetURL(), {})
       driver.quit()
 
   def testSessionCommandsAfterSessionDeletionReturn404(self):
-    driver = WebDriver(self._launcher.GetURL(), 'chrome', 'any')
+    driver = WebDriver(self._launcher.GetURL(), {})
     session_id = driver.session_id
     driver.quit()
     try:
@@ -223,7 +223,7 @@
   def testMultipleConcurrentSessions(self):
     drivers = []
     for i in range(10):
-      drivers += [WebDriver(self._launcher.GetURL(), 'chrome', 'any')]
+      drivers += [WebDriver(self._launcher.GetURL(), {})]
     for driver in drivers:
       driver.quit()
 
@@ -233,7 +233,7 @@
 
   def setUp(self):
     self._launcher = ChromeDriverLauncher(root_path=os.path.dirname(__file__))
-    self._driver = WebDriver(self._launcher.GetURL(), 'chrome', 'any')
+    self._driver = WebDriver(self._launcher.GetURL(), {})
 
   def tearDown(self):
     self._driver.quit()