Allow webdriver users to choose between sending the key events when...

chrome/test/webdriver/automation.cc

Index: chrome/test/webdriver/automation.cc
===================================================================
--- chrome/test/webdriver/automation.cc	(revision 76851)
+++ chrome/test/webdriver/automation.cc	(working copy)
@@ -242,11 +242,16 @@
 
 void Automation::SendWebKeyEvent(int tab_id,

[kkania, 2011/03/10 00:28:58]

I would prefer creating a separate method here for sending native events, since
they call two different commands and should have different arguments.

[timothe faudot, 2011/03/10 05:34:32]

Done. I created a SendNativeWebKeyEvent uses different json args (only those
necessary for the event to be handled in ui_controls::SendKeyPress)

                                  const WebKeyEvent& key_event,
+                                 bool use_native_events,
                                  bool* success) {
   std::string reply;
   DictionaryValue dict;
 
-  dict.SetString("command", "SendKeyEventToActiveTab");
+  if (use_native_events){
+    dict.SetString("command", "SendKeyEventToActiveBrowserWindow");

[kkania, 2011/03/10 00:28:58]

Modify the command name to say something about the fact that they are simulating
OS-level keyboard input.

[timothe faudot, 2011/03/10 05:34:32]

Changed to SendOSLevelKeyEvent

+  } else {
+    dict.SetString("command", "SendKeyEventToActiveTab");
+  }
   dict.SetInteger("type", key_event.type);
   dict.SetInteger("nativeKeyCode", key_event.key_code);
   dict.SetInteger("windowsKeyCode", key_event.key_code);