Allow webdriver users to choose between sending the key events when...

chrome/browser/automation/testing_automation_provider.h

Index: chrome/browser/automation/testing_automation_provider.h
===================================================================
--- chrome/browser/automation/testing_automation_provider.h	(revision 77771)
+++ chrome/browser/automation/testing_automation_provider.h	(working copy)
@@ -754,12 +754,11 @@
                            DictionaryValue* args,
                            IPC::Message* reply_message);
 
-  // Sends a web keyboard event to the active tab. This should not trigger any
-  // browser hotkeys.
-  // Uses the JSON interface for input/output.
-  void SendKeyEventToActiveTab(Browser* browser,
-                               DictionaryValue* args,
-                               IPC::Message* reply_message);
+  // Populates the fields of the event parameters with what is found
+  // on the args one.
+  bool BuildWebKeyEventFromArgs(DictionaryValue* args,
+                                IPC::Message* reply_message,
+                                NativeWebKeyboardEvent* event);
 
   // Determines whether each relevant section of the NTP is in thumbnail mode.
   void GetNTPThumbnailMode(Browser* browser,
@@ -959,6 +958,20 @@
   void SendWebkitKeyEvent(DictionaryValue* args,
                           IPC::Message* message);
 
+  // Sends the WebKit key event from the OS level to the browser window,

[kkania, 2011/03/11 16:32:13]

you're not sending a webkit key event, you're simulating OS level key input;
please cleanup the comment

[timothe, 2011/03/21 18:02:05]

Done.

+  // allowing it to be preprocessed by some external application (ie. IME).
+  // Example:
+  //   input: { "windex": 1,
+  //            "tab_index": 1,
+  //            "type": automation::kRawKeyDownType,

[kkania, 2011/03/11 16:32:13]

you don't use type anymore do you?

[timothe, 2011/03/21 18:02:05]

Done, I removed it.

+  //            "nativeKeyCode": ui::VKEY_X,
+  //            "windowsKeyCode": ui::VKEY_X,
+  //            "modifiers": automation::kShiftKeyMask,
+  //          }
+  //   output: none
+  void SendOSLevelKeyEvent(DictionaryValue* args,
+                           IPC::Message* message);
+
   // Activates the given tab.
   // Example:
   //   input: { "windex": 1,