Allow webdriver users to choose between sending the key events when...

chrome/browser/automation/testing_automation_provider.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOMATION_TESTING_AUTOMATION_PROVIDER_H_
 #define CHROME_BROWSER_AUTOMATION_TESTING_AUTOMATION_PROVIDER_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/scoped_ptr.h"
@@ skipping 736 matching lines @@
   void RestoreAllNTPMostVisitedThumbnails(Browser* browser,
                                           DictionaryValue* args,
                                           IPC::Message* reply_message);
 
   // Kills the given renderer process and returns after the associated
   // RenderProcessHost receives notification of its closing.
   void KillRendererProcess(Browser* browser,
                            DictionaryValue* args,
                            IPC::Message* reply_message);
 
-  // Sends a web keyboard event to the active tab. This should not trigger any
-  // browser hotkeys.
-  // Uses the JSON interface for input/output.
-  void SendKeyEventToActiveTab(Browser* browser,
-                               DictionaryValue* args,
-                               IPC::Message* reply_message);
+  // Populates the fields of the event parameters with what is found
+  // on the args one.
+  bool BuildWebKeyEventFromArgs(DictionaryValue* args,
+                                IPC::Message* reply_message,
+                                NativeWebKeyboardEvent* event);
 
   // Determines whether each relevant section of the NTP is in thumbnail mode.
   void GetNTPThumbnailMode(Browser* browser,
                            DictionaryValue* args,
                            IPC::Message* reply_message);
 
   // Puts or removes the specified section of the NTP into/from thumbnail mode.
   // If the section is put into thumbnail mode, all other relevant sections are
   // removed from thumbnail mode.
   void SetNTPThumbnailMode(Browser* browser,
@@ skipping 179 matching lines @@
   //            "windowsKeyCode": ui::VKEY_X,
   //            "unmodifiedText": "x",
   //            "text": "X",
   //            "modifiers": automation::kShiftKeyMask,
   //            "isSystemKey": false
   //          }
   //   output: none
   void SendWebkitKeyEvent(DictionaryValue* args,
                           IPC::Message* message);
 
+  // Sends the WebKit key event from the OS level to the browser window,

[kkania, 2011/03/11 16:32:13]

you're not sending a webkit key event, you're simulating OS level key input;
please cleanup the comment

[timothe, 2011/03/21 18:02:05]

Done.

+  // allowing it to be preprocessed by some external application (ie. IME).
+  // Example:
+  //   input: { "windex": 1,
+  //            "tab_index": 1,
+  //            "type": automation::kRawKeyDownType,

[kkania, 2011/03/11 16:32:13]

you don't use type anymore do you?

[timothe, 2011/03/21 18:02:05]

Done, I removed it.

+  //            "nativeKeyCode": ui::VKEY_X,
+  //            "windowsKeyCode": ui::VKEY_X,
+  //            "modifiers": automation::kShiftKeyMask,
+  //          }
+  //   output: none
+  void SendOSLevelKeyEvent(DictionaryValue* args,
+                           IPC::Message* message);
+
   // Activates the given tab.
   // Example:
   //   input: { "windex": 1,
   //            "tab_index": 1,
   //          }
   //   output: none
   void ActivateTabJSON(DictionaryValue* args, IPC::Message* message);
 
 #if defined(OS_CHROMEOS)
   void LoginAsGuest(DictionaryValue* args, IPC::Message* reply_message);
@@ skipping 74 matching lines @@
   // Used to enumerate browser profiles.
   scoped_refptr<ImporterList> importer_list_;
 
   // The stored data for the ImportSettings operation.
   ImportSettingsData import_settings_data_;
 
   DISALLOW_COPY_AND_ASSIGN(TestingAutomationProvider);
 };
 
 #endif  // CHROME_BROWSER_AUTOMATION_TESTING_AUTOMATION_PROVIDER_H_