Fix the settings page for es-419 locale: Spanish (Latin America).

Fix the settings page for es-419 locale: Spanish (Latin America).

Before the fix, the settings page for es-419 was half broken as there
was an JavaScript error like below while loading the page.

    Uncaught TypeError: Cannot read property 'name' of undefined

The error was caused by the fact that "419" isn't a valid country code.

BUG=chromium-os:12857
TEST=open the "Languages and Input" settings on Chromium OS, and confirmed that it's shown correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77402

[satorux1, 2011-03-08 10:20:37]

I haven't tested but this issue probably reproduces on platforms other than
Chrome OS. This issue may be P1, thus the change may be worth merging to M11...

[Ilya Sherman, 2011-03-08 10:35:18]

Thanks for tracking this down!  I agree that we should probably merge this to
M11.

http://codereview.chromium.org/6626070/diff/1/chrome/browser/autofill/autofil...
File chrome/browser/autofill/autofill_country.cc (right):

http://codereview.chromium.org/6626070/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_country.cc:394: std::string::npos)
Probably the right check here is actually to see if the country code is in the
map of known countries:

if (!AutofillCountries::countries().count(country_code))
  return "US";

[satorux1, 2011-03-08 11:28:10]

http://codereview.chromium.org/6626070/diff/1/chrome/browser/autofill/autofil...
File chrome/browser/autofill/autofill_country.cc (right):

http://codereview.chromium.org/6626070/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_country.cc:394: std::string::npos)
On 2011/03/08 10:35:18, Ilya Sherman wrote:
> Probably the right check here is actually to see if the country code is in the
> map of known countries:
> 
> if (!AutofillCountries::countries().count(country_code))
>   return "US";

Done.

[Ilya Sherman, 2011-03-08 22:15:19]

LGTM, thanks!