Issue 6626039: Revert "Plumb in crprocess instead of RunCommand to allow quiet operation."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6626039: Revert "Plumb in crprocess instead of RunCommand to allow quiet operation." (Closed)

Created:
9 years, 9 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
sjg

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/chromite.git@master

Visibility:
Public.

Description

Revert "Plumb in crprocess instead of RunCommand to allow quiet operation." sjg asked me to help revert his commit to fix the buildbots. This reverts commit 77a59c0dc2b1f621dcdf0e8b99b873f4998bd691. BUG= TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0315636

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -268 lines)			Patch
M	lib/cros_build_lib.py	View	3 chunks	+8 lines, -14 lines	0 comments	Download
M	lib/cros_subprocess.py	View	19 chunks	+23 lines, -45 lines	0 comments	Download
M	lib/operation.py	View	9 chunks	+33 lines, -34 lines	0 comments	Download
M	shell/chromite_env.py	View	2 chunks	+0 lines, -80 lines	0 comments	Download
M	shell/main.py	View	6 chunks	+14 lines, -32 lines	0 comments	Download
M	shell/main_unittest.py	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	shell/subcmd.py	View	5 chunks	+9 lines, -7 lines	0 comments	Download
M	shell/subcmds/build_cmd.py	View	4 chunks	+74 lines, -35 lines	0 comments	Download
M	shell/subcmds/clean_cmd.py	View	4 chunks	+13 lines, -10 lines	0 comments	Download
M	shell/subcmds/portage_cmds.py	View	4 chunks	+0 lines, -4 lines	0 comments	Download
M	shell/subcmds/shell_cmd.py	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	shell/subcmds/workon_cmd.py	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	shell/utils.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages