Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: shell/subcmds/shell_cmd.py

Issue 6626039: Revert "Plumb in crprocess instead of RunCommand to allow quiet operation." (Closed) Base URL: http://git.chromium.org/git/chromite.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/subcmds/portage_cmds.py ('k') | shell/subcmds/workon_cmd.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/subcmds/shell_cmd.py
diff --git a/shell/subcmds/shell_cmd.py b/shell/subcmds/shell_cmd.py
index 538ebf008f7790a9c7c41f28fc52d3196b75b77d..4c3c550252b067c92399082989ee9802babb4e71 100644
--- a/shell/subcmds/shell_cmd.py
+++ b/shell/subcmds/shell_cmd.py
@@ -93,7 +93,6 @@ class ShellCmd(subcmd.ChromiteCmd):
# Enter the chroot if needed...
if not cros_lib.IsInsideChroot():
- self._oper.Info('ENTERING THE CHROOT')
utils.EnterChroot(chroot_config, (self, 'Run'), raw_argv)
else:
# We'll put CWD as src/scripts when running the command. Since everyone
@@ -121,8 +120,5 @@ class ShellCmd(subcmd.ChromiteCmd):
env.update(user_env)
# Don't show anything special for errors; we'll let the shell report them.
- # TODO(sjg) We don't use RunScript() here since this may become an
- # interactive shell. Would prefer that this becomes its own command to
- # avoid this problem.
cros_lib.RunCommand(argv, cwd=cwd, env=env, error_ok=True,
ignore_sigint=True)
« no previous file with comments | « shell/subcmds/portage_cmds.py ('k') | shell/subcmds/workon_cmd.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698