Issue 6626033: An RSA SSL server certificate whose Key Usage extension...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6626033: An RSA SSL server certificate whose Key Usage extension... (Closed)

Created:
9 years, 9 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

An RSA SSL server certificate whose Key Usage extension doesn't have the keyEncipherment bit should be reported as CERT_STATUS_INVALID. Map more NSS certificate errors. R=rsleevi BUG=70293 TEST=net_unittests --gtest_filter=X509CertificateTest.InvalidKeyUsage Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77661

Patch Set 1 #

Patch Set 2 : Add comments to the new unit test #

Patch Set 3 : Map more NSS certificate errors #

Patch Set 4 : Add invalid_key_usage_cert.der separately #

Patch Set 5 : Comment out the untrusted CA check for USE_NSS #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	net/base/x509_certificate_nss.cc	View	1 2 3	4 chunks	+15 lines, -0 lines	0 comments	Download
	M	net/base/x509_certificate_unittest.cc	View	1 2 3 4	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Try job failure for 6626033-7003 on win: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=20255

9 years, 9 months ago (2011-03-10 01:18:55 UTC) #3

Change committed as 77661

Expand Messages | Collapse Messages