Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: net/base/x509_certificate_nss.cc

Issue 6626033: An RSA SSL server certificate whose Key Usage extension... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Comment out the untrusted CA check for USE_NSS Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/x509_certificate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_certificate_nss.cc
===================================================================
--- net/base/x509_certificate_nss.cc (revision 77209)
+++ net/base/x509_certificate_nss.cc (working copy)
@@ -98,6 +98,7 @@
return ERR_CERT_COMMON_NAME_INVALID;
case SEC_ERROR_INVALID_TIME:
case SEC_ERROR_EXPIRED_CERTIFICATE:
+ case SEC_ERROR_EXPIRED_ISSUER_CERTIFICATE:
return ERR_CERT_DATE_INVALID;
case SEC_ERROR_UNKNOWN_ISSUER:
case SEC_ERROR_UNTRUSTED_ISSUER:
@@ -111,7 +112,13 @@
case SEC_ERROR_CERT_NOT_VALID:
// TODO(port): add an ERR_CERT_WRONG_USAGE error code.
case SEC_ERROR_CERT_USAGES_INVALID:
+ case SEC_ERROR_INADEQUATE_KEY_USAGE:
+ case SEC_ERROR_INADEQUATE_CERT_TYPE:
case SEC_ERROR_POLICY_VALIDATION_FAILED:
+ case SEC_ERROR_CERT_NOT_IN_NAME_SPACE:
+ case SEC_ERROR_PATH_LEN_CONSTRAINT_INVALID:
+ case SEC_ERROR_UNKNOWN_CRITICAL_EXTENSION:
+ case SEC_ERROR_EXTENSION_VALUE_INVALID:
return ERR_CERT_INVALID;
default:
LOG(WARNING) << "Unknown error " << err << " mapped to net::ERR_FAILED";
@@ -126,6 +133,7 @@
return CERT_STATUS_COMMON_NAME_INVALID;
case SEC_ERROR_INVALID_TIME:
case SEC_ERROR_EXPIRED_CERTIFICATE:
+ case SEC_ERROR_EXPIRED_ISSUER_CERTIFICATE:
return CERT_STATUS_DATE_INVALID;
case SEC_ERROR_UNTRUSTED_CERT:
case SEC_ERROR_UNKNOWN_ISSUER:
@@ -143,7 +151,14 @@
case SEC_ERROR_CERT_NOT_VALID:
// TODO(port): add a CERT_STATUS_WRONG_USAGE error code.
case SEC_ERROR_CERT_USAGES_INVALID:
+ case SEC_ERROR_INADEQUATE_KEY_USAGE: // Key usage.
+ case SEC_ERROR_INADEQUATE_CERT_TYPE: // Extended key usage and whether
+ // the certificate is a CA.
case SEC_ERROR_POLICY_VALIDATION_FAILED:
+ case SEC_ERROR_CERT_NOT_IN_NAME_SPACE:
+ case SEC_ERROR_PATH_LEN_CONSTRAINT_INVALID:
+ case SEC_ERROR_UNKNOWN_CRITICAL_EXTENSION:
+ case SEC_ERROR_EXTENSION_VALUE_INVALID:
return CERT_STATUS_INVALID;
default:
return 0;
« no previous file with comments | « no previous file | net/base/x509_certificate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698