Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 6626016: Add support for SDRAM registers printing to bct_dump. (Closed)

Created:
9 years, 9 months ago by Vincent Palatin
Modified:
9 years, 7 months ago
Reviewers:
pchen, robotboy
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add support for SDRAM registers printing to bct_dump. This adds human readable output for RAM controller registers default values stored in a BCT file. BUG=None TEST=bct_dump burn-u-boot/bct/default.bct and check EMC_CFG value. This CL depends on http://codereview.chromium.org/6625006/ Change-Id: I4451d17c144d0273d375e490511e2534accd6de1

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix review comments #

Patch Set 3 : Rebase against master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -0 lines) Patch
M bct_dump.c View 1 3 chunks +235 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vincent Palatin
9 years, 9 months ago (2011-03-04 17:43:16 UTC) #1
robotboy
9 years, 9 months ago (2011-03-04 18:10:54 UTC) #2
LGTM, after addressing comments below.

Thanks,
    Anton

http://codereview.chromium.org/6626016/diff/1/bct_dump.c
File bct_dump.c (right):

http://codereview.chromium.org/6626016/diff/1/bct_dump.c#newcode434
bct_dump.c:434: for (j = 0; j < sizeof(sdram_values) / sizeof(sdram_values[0]);
++j) {
Please wrap to 80-columns.

http://codereview.chromium.org/6626016/diff/1/bct_dump.c#newcode439
bct_dump.c:439: printf(sdram_values[j].message, e == 0 ? data : 0x0bad0bad);
For consistency let's leave this as -1 as well.  I am working on a rewrite of
the way bct_dump handles printing values.  The result will be that if a value
fails to read we'll get something more like <error> instead of 0xffffffff which
could conceivably be a valid value.

Powered by Google App Engine
This is Rietveld 408576698