Issue 6623071: Fix AutomationProvider from logging false errors by replacing the persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6623071: Fix AutomationProvider from logging false errors by replacing the persistent (Closed)

Created:
9 years, 9 months ago by kkania

Modified:
9 years, 7 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, kkania, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix AutomationProvider from logging false errors by replacing the persistent DOM operation observer with one per message. Also merge the two DOM operation observers for the different automation calls into one. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77654

Patch Set 1 #

Patch Set 2 : little fix #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -57 lines)			Patch
M	chrome/browser/automation/automation_provider.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.h	View		2 chunks	+7 lines, -19 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.cc	View		2 chunks	+17 lines, -32 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages