Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/automation/automation_provider.h

Issue 6623071: Fix AutomationProvider from logging false errors by replacing the persistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: little fix Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/automation/automation_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This implements a browser-side endpoint for UI automation activity. 5 // This implements a browser-side endpoint for UI automation activity.
6 // The client-side endpoint is implemented by AutomationProxy. 6 // The client-side endpoint is implemented by AutomationProxy.
7 // The entire lifetime of this object should be contained within that of 7 // The entire lifetime of this object should be contained within that of
8 // the BrowserProcess, and in particular the NotificationService that's 8 // the BrowserProcess, and in particular the NotificationService that's
9 // hung off of it. 9 // hung off of it.
10 10
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 void OnSetZoomLevel(int handle, int zoom_level); 382 void OnSetZoomLevel(int handle, int zoom_level);
383 383
384 ExternalTabContainer* GetExternalTabForHandle(int handle); 384 ExternalTabContainer* GetExternalTabForHandle(int handle);
385 #endif // defined(OS_WIN) 385 #endif // defined(OS_WIN)
386 386
387 typedef std::map<int, ExtensionPortContainer*> PortContainerMap; 387 typedef std::map<int, ExtensionPortContainer*> PortContainerMap;
388 388
389 scoped_ptr<IPC::ChannelProxy> channel_; 389 scoped_ptr<IPC::ChannelProxy> channel_;
390 scoped_ptr<NotificationObserver> new_tab_ui_load_observer_; 390 scoped_ptr<NotificationObserver> new_tab_ui_load_observer_;
391 scoped_ptr<NotificationObserver> find_in_page_observer_; 391 scoped_ptr<NotificationObserver> find_in_page_observer_;
392 scoped_ptr<NotificationObserver> dom_operation_observer_;
393 scoped_ptr<ExtensionTestResultNotificationObserver> 392 scoped_ptr<ExtensionTestResultNotificationObserver>
394 extension_test_result_observer_; 393 extension_test_result_observer_;
395 scoped_ptr<AutomationExtensionTracker> extension_tracker_; 394 scoped_ptr<AutomationExtensionTracker> extension_tracker_;
396 PortContainerMap port_containers_; 395 PortContainerMap port_containers_;
397 396
398 // True iff connected to an AutomationProxy. 397 // True iff connected to an AutomationProxy.
399 bool is_connected_; 398 bool is_connected_;
400 399
401 // True iff browser finished loading initial set of tabs. 400 // True iff browser finished loading initial set of tabs.
402 bool initial_loads_complete_; 401 bool initial_loads_complete_;
403 402
404 // ID of automation channel. 403 // ID of automation channel.
405 std::string channel_id_; 404 std::string channel_id_;
406 405
407 DISALLOW_COPY_AND_ASSIGN(AutomationProvider); 406 DISALLOW_COPY_AND_ASSIGN(AutomationProvider);
408 }; 407 };
409 408
410 #endif // CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_H_ 409 #endif // CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/automation/automation_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698