[Mac] Remove native/Cocoa preferences.

chrome/common/chrome_switches.cc

Index: chrome/common/chrome_switches.cc
diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc
index cd560e37c0f54cd79acec9bc382797cf8205a789..9f7b0aa342c5ad26f8cb3e13548fc778127d8144 100644
--- a/chrome/common/chrome_switches.cc
+++ b/chrome/common/chrome_switches.cc
@@ -358,7 +358,14 @@ const char kDisableSyncPreferences[]        = "disable-sync-preferences";
 const char kDisableSyncThemes[]             = "disable-sync-themes";
 
 // Disable tabbed options, i.e., WebUI version of options window.
+#if defined(OS_MACOSX)
+// Platforms that have removed their native implementations should use this flag
+// so users aren't left with a bad experience if they used it still. Remove this
+// when all native implementations are done.
+const char kDisableTabbedOptions[]           = "snoitpo-debbat-elbasid";

[stuartmorgan, 2011/03/08 20:27:48]

Really?

Couldn't we just #ifdef the uses of the flag? There aren't *that* many.

[Robert Sesek, 2011/03/08 20:33:20]

I looked at that, and it gets seriously ugly because the common use is:

if (...kDisabledTabbedOptions) {
} else {
}

Which would turn into:

#if defined(OS_MACOSX)
if (...) {
} else {
#endif
...
#if ...
}
#endif

Or

#if defined(OS_MACOSX)
if (false) {
#else
if (...kDisabled...) {
#endif

Not to mention every platform will then have to go back and modify it when they
do this. This seems like a much saner solution to me.

+#else
 const char kDisableTabbedOptions[]           = "disable-tabbed-options";
+#endif
 
 // TabCloseableStateWatcher disallows closing of tabs and browsers under certain
 // situations on ChromeOS.  Some tests expect tabs or browsers to close, so we