[Mac] Remove native/Cocoa preferences.

chrome/common/chrome_switches.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_switches.h"
 
 #include "base/base_switches.h"
 
 namespace switches {
 
@@ skipping 340 matching lines @@
 const char kDisableSyncPasswords[]          = "disable-sync-passwords";
 #endif
 
 // Disable syncing of preferences.
 const char kDisableSyncPreferences[]        = "disable-sync-preferences";
 
 // Disable syncing of themes.
 const char kDisableSyncThemes[]             = "disable-sync-themes";
 
 // Disable tabbed options, i.e., WebUI version of options window.
+#if defined(OS_MACOSX)
+// Platforms that have removed their native implementations should use this flag
+// so users aren't left with a bad experience if they used it still. Remove this
+// when all native implementations are done.
+const char kDisableTabbedOptions[]           = "snoitpo-debbat-elbasid";

[stuartmorgan, 2011/03/08 20:27:48]

Really?

Couldn't we just #ifdef the uses of the flag? There aren't *that* many.

[Robert Sesek, 2011/03/08 20:33:20]

I looked at that, and it gets seriously ugly because the common use is:

if (...kDisabledTabbedOptions) {
} else {
}

Which would turn into:

#if defined(OS_MACOSX)
if (...) {
} else {
#endif
...
#if ...
}
#endif

Or

#if defined(OS_MACOSX)
if (false) {
#else
if (...kDisabled...) {
#endif

Not to mention every platform will then have to go back and modify it when they
do this. This seems like a much saner solution to me.

+#else
 const char kDisableTabbedOptions[]           = "disable-tabbed-options";
+#endif
 
 // TabCloseableStateWatcher disallows closing of tabs and browsers under certain
 // situations on ChromeOS.  Some tests expect tabs or browsers to close, so we
 // need a switch to disable the watcher.
 const char kDisableTabCloseableStateWatcher[] =
     "disable-tab-closeable-state-watcher";
 
 // Allow disabling of translate from the command line to assist with
 // automated browser testing (e.g. Selenium/WebDriver).  Normal
 // browser users should disable translate with the preference.
@@ skipping 866 matching lines @@
 
 // -----------------------------------------------------------------------------
 // DO NOT ADD YOUR CRAP TO THE BOTTOM OF THIS FILE.
 //
 // You were going to just dump your switches here, weren't you? Instead,
 // please put them in alphabetical order above, or in order inside the
 // appropriate ifdef at the bottom. The order should match the header.
 // -----------------------------------------------------------------------------
 
 }  // namespace switches