[Mac] Remove native/Cocoa preferences.

[Mac] Remove native/Cocoa preferences.

BUG=73011
TEST=Tabbed options work as before. --disable-tabbed-options does nothing.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77477

[stuartmorgan, 2011-03-08 20:27:48]

http://codereview.chromium.org/6621076/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/6621076/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:365: const char kDisableTabbedOptions[]        
  = "snoitpo-debbat-elbasid";
Really?

Couldn't we just #ifdef the uses of the flag? There aren't *that* many.

[Robert Sesek, 2011-03-08 20:33:19]

http://codereview.chromium.org/6621076/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/6621076/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:365: const char kDisableTabbedOptions[]        
  = "snoitpo-debbat-elbasid";
On 2011/03/08 20:27:48, stuartmorgan wrote:
> Really?
> 
> Couldn't we just #ifdef the uses of the flag? There aren't *that* many.

I looked at that, and it gets seriously ugly because the common use is:

if (...kDisabledTabbedOptions) {
} else {
}

Which would turn into:

#if defined(OS_MACOSX)
if (...) {
} else {
#endif
...
#if ...
}
#endif

Or

#if defined(OS_MACOSX)
if (false) {
#else
if (...kDisabled...) {
#endif

Not to mention every platform will then have to go back and modify it when they
do this. This seems like a much saner solution to me.

[stuartmorgan, 2011-03-08 21:14:59]

I just talked to James about this, and realized that we could just flip the
order here: remove the flag first, then the native implementations. It doesn't
hurt to have the native code inaccessible for the brief period before we remove
it.

[Robert Sesek, 2011-03-08 21:17:51]

On Tue, Mar 8, 2011 at 4:14 PM, <stuartmorgan@chromium.org> wrote:

> I just talked to James about this, and realized that we could just flip the
> order here: remove the flag first, then the native implementations. It
> doesn't
> hurt to have the native code inaccessible for the brief period before we
> remove
> it.
>  <http://codereview.chromium.org/6621076/>
>

Yes, James and I have been talking offline. This approach makes the most
sense, I think (and requires no nasty hacks :).

http://codereview.chromium.org/6621076/

[Robert Sesek, 2011-03-09 15:06:57]

I've rebased James' changes and this is now ready for another look.

[stuartmorgan, 2011-03-09 15:57:24]

LGTM.

We should make sure there's a bug or TODO to do more cleanup once all the
platforms have removed the native prefs, so we don't have a bunch of dead APIs
sticking around.