Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 6621041: crosutils/mod_for_factory_scripts: don't change VT on factory service stop (Closed)

Created:
9 years, 9 months ago by Hung-Te
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

crosutils/mod_for_factory_scripts: don't change VT on factory service stop In http://codereview.chromium.org/6567004 in order to help developers stopping factory UI, we've added an "chvt 2". However changing foreground terminal may hang when executing "shutdown -r" inside Wipe test. Removing the "chvt" call solved this issue. The only side effect is that developers executing "initctl stop factory" may end seeing a black scren - and they need to hit Ctrl-Alt-F2 to get the console back. BUG=chrome-os-partner:2631 TEST=build a factory image then verified following steps: (1) in VT2, do "initctl stop factory, then C-A-F2: screen changed to VT2. (2) Execute factory tests until Wipe: reboots immediately when X closed (3) Execute Reboot in HWID test: reboots immediately when 'reboot' is ACTIVE Change-Id: Ib6f44a6ad07db08862929179d0fe21cbbcc2b22a Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c750ac2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M mod_for_factory_scripts/200patchInitScript View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hung-Te
9 years, 9 months ago (2011-03-07 10:29:06 UTC) #1
Nick Sanders
lgtm
9 years, 9 months ago (2011-03-07 17:11:53 UTC) #2
Hung-Te
9 years, 9 months ago (2011-03-08 01:25:01 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698