Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6621025: Move socket stream messages to content, in preparation for moving its dispatc... (Closed)

Created:
9 years, 9 months ago by jam
Modified:
8 years, 11 months ago
Reviewers:
ukai, germany1937
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, Paweł Hajdan Jr., kkania, darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Move socket stream messages to content, in preparation for moving its dispatcher. In this change I also converted p2p_messages to use the new automated way of serializing structs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77019

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -224 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/importer_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/autofill_messages.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/automation_messages.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/common_param_traits.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/common/common_param_traits.cc View 2 chunks +1 line, -19 lines 0 comments Download
M chrome/common/common_param_traits_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/dom_storage_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/net/socket_stream.h View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/common/plugin_messages.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 2 chunks +0 lines, -60 lines 0 comments Download
M chrome/common/socket_stream_dispatcher.cc View 8 chunks +17 lines, -19 lines 0 comments Download
M chrome/common/utility_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.cc View 8 chunks +23 lines, -19 lines 0 comments Download
M content/browser/renderer_host/socket_stream_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A content/common/common_param_traits.h View 1 1 chunk +40 lines, -0 lines 0 comments Download
A content/common/common_param_traits.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A content/common/content_constants.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A content/common/content_constants.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
A content/common/content_message_generator.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
A content/common/content_message_generator.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M content/common/p2p_messages.h View 2 chunks +8 lines, -22 lines 0 comments Download
D content/common/p2p_messages.cc View 1 chunk +0 lines, -31 lines 0 comments Download
A + content/common/socket_stream.h View 1 chunk +4 lines, -4 lines 0 comments Download
A content/common/socket_stream_messages.h View 1 chunk +71 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +13 lines, -6 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jam
9 years, 9 months ago (2011-03-05 00:53:51 UTC) #1
jam
9 years, 9 months ago (2011-03-05 00:53:51 UTC) #2
ukai
LGTM
9 years, 9 months ago (2011-03-05 08:42:01 UTC) #3
germany1937
On 2011/03/05 08:42:01, ukai wrote:
8 years, 11 months ago (2012-01-12 11:03:32 UTC) #4
germany1937
On 2012/01/12 11:03:32, germany1937 wrote:
8 years, 11 months ago (2012-01-12 11:04:47 UTC) #5
germany1937
On 2011/03/05 00:53:51, John Abd-El-Malek wrote:
8 years, 11 months ago (2012-01-12 11:07:19 UTC) #6
germany1937
On 2011/03/05 00:53:51, John Abd-El-Malek wrote:
8 years, 11 months ago (2012-01-12 11:07:48 UTC) #7
germany1937
On 2012/01/12 11:07:48, germany1937 wrote:
8 years, 11 months ago (2012-01-12 11:09:07 UTC) #8
germany1937
lgtm
8 years, 11 months ago (2012-01-12 11:15:48 UTC) #9
germany1937
lgtm
8 years, 11 months ago (2012-01-12 11:15:53 UTC) #10
germany1937
8 years, 11 months ago (2012-01-12 11:20:27 UTC) #11 
C:\Users\Ashes\Desktop\Chrome SxS\Application\chrome.exe

Powered by Google App Engine
This is Rietveld 408576698