Issue 661473: Don't build a binary package for autotest because we're not using it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661473: Don't build a binary package for autotest because we're not using it. (Closed)

Created:
10 years, 9 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Don't build a binary package for autotest because we're not using it. This saves almost 1 minute (out of 6) on my build host for the current full build_autotest.sh. The savings will be more significant once the Chrome tests (200MB+) also get into autotest. Alternatively, we could still build the binary package and use it as part of archive_build.sh (i.e., just copy it there instead of creating a new one). But most people don't run archive_build so it may be better to not create the binary package as part of build_autotest.sh.

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/scripts/build_autotest.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 9 months ago (2010-03-03 17:58:20 UTC) #2

LGTM

On Wed, Mar 3, 2010 at 9:35 AM,  <petkov@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Don't build a binary package for autotest because we're not using it.
> This saves almost 1 minute (out of 6) on my build host for the current full
> build_autotest.sh. The savings will be more significant once the Chrome
> tests
> (200MB+) also get into autotest.
>
> Alternatively, we could still build the binary package and use it as part of
> archive_build.sh (i.e., just copy it there instead of creating a new one).
> But most people don't run archive_build so it may be better to not create
> the binary package as part of build_autotest.sh.
>
> Please review this at http://codereview.chromium.org/661473
>
> Affected files:
>  M src/scripts/build_autotest.sh
>
>
> Index: src/scripts/build_autotest.sh
> diff --git a/src/scripts/build_autotest.sh b/src/scripts/build_autotest.sh
> index
>
e9a3e123cdb3c88a5a9bb1bd970fbbfea8325279..98a5029056fdc59352836cada99cf3db076c81ac
> 100755
> --- a/src/scripts/build_autotest.sh
> +++ b/src/scripts/build_autotest.sh
> @@ -72,5 +72,5 @@ else
>   USE=-autox
>  fi
>
> -GCLIENT_ROOT="${GCLIENT_ROOT}" TEST_LIST=${TEST_LIST} \
> +GCLIENT_ROOT="${GCLIENT_ROOT}" TEST_LIST=${TEST_LIST} FEATURES="-buildpkg"
> \
>   USE="$USE" "emerge-${FLAGS_board}" chromeos-base/autotest
>
>
>

Expand Messages | Collapse Messages