Issue 661392: Refactor libcros calls for ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661392: Refactor libcros calls for ChromeOS (Closed)

Created:
10 years, 9 months ago by Charlie Lee

Modified:
9 years, 7 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactor libcros calls for ChromeOS - better UI for why libcros failed to load - fix enable/disable wifi menu item - call new ConnectToNetwork method that works with cellular BUG=1682 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40790

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -75 lines)			Patch
	M	chrome/browser/chromeos/cros/network_library.h	View	1 2 3	5 chunks	+29 lines, -20 lines	0 comments	Download
	M	chrome/browser/chromeos/cros/network_library.cc	View	1 2 3	4 chunks	+28 lines, -55 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Charlie Lee

Dave, this the UI changes that's needed for the libcros change: http://codereview.chromium.org/652187

10 years, 9 months ago (2010-03-05 02:10:39 UTC) #1

DaveMoore

http://codereview.chromium.org/661392/diff/2012/2019 File chrome/browser/chromeos/cros/cros_library.cc (right): http://codereview.chromium.org/661392/diff/2012/2019#newcode30 chrome/browser/chromeos/cros/cros_library.cc:30: LOG(ERROR) << "libcros error: " << error_; I have ...

10 years, 9 months ago (2010-03-05 18:12:16 UTC) #2

Charlie Lee

10 years, 9 months ago (2010-03-05 20:53:37 UTC) #3

LGTM

Expand Messages | Collapse Messages