Added ConnectToNetwork

Added ConnectToNetwork

[Charlie Lee, 2010-02-24 00:51:11]

Dave, due to the likely breakage of libcros, I will wait until R5 is out before
committing this change.

[Charlie Lee, 2010-02-26 23:14:47]

Sam, can you take a look at the new method I added. I'm not sure it will work
but I can't test it right now. But we definitely need something different than
wifi.

[Sam Leffler, 2010-02-26 23:20:24]

LGTM

[Charlie Lee, 2010-03-05 02:09:47]

Here's the new libcros work that will use Service.Connect() to connect to
networks. I went ahead and overhauled a lot of our code. So, unfortunately, this
will not be backwards compatible.

[DaveMoore, 2010-03-05 18:22:33]

http://codereview.chromium.org/652187/diff/5021/4004
File chromeos_cros_api.h (left):

http://codereview.chromium.org/652187/diff/5021/4004#oldcode69
chromeos_cros_api.h:69: 
This is dependent on Chrome not calling the old API. Both you and I have cls
that make that so, but we should wait until after those changes have been
landed.

http://codereview.chromium.org/652187/diff/5021/4005
File chromeos_network.cc (right):

http://codereview.chromium.org/652187/diff/5021/4005#newcode339
chromeos_network.cc:339: if (info.service_path)
Since info is still extant after this call, if you delete fields you should NULL
them out. This makes bugs where something accesses them incorrectly easier to
find.

http://codereview.chromium.org/652187/diff/5021/4007
File load.cc (left):

http://codereview.chromium.org/652187/diff/5021/4007#oldcode139
load.cc:139: }
Leave this in until the chrome change is landed (not just in the air). Plus that
should be a change all by itself so it's more easily unwound if there's a
problem.

[Charlie Lee, 2010-03-05 20:02:04]

http://codereview.chromium.org/652187/diff/5021/4004
File chromeos_cros_api.h (left):

http://codereview.chromium.org/652187/diff/5021/4004#oldcode69
chromeos_cros_api.h:69: 
On 2010/03/05 18:22:33, davemoore wrote:
> This is dependent on Chrome not calling the old API. Both you and I have cls
> that make that so, but we should wait until after those changes have been
> landed.

Done.

http://codereview.chromium.org/652187/diff/5021/4005
File chromeos_network.cc (right):

http://codereview.chromium.org/652187/diff/5021/4005#newcode339
chromeos_network.cc:339: if (info.service_path)
On 2010/03/05 18:22:33, davemoore wrote:
> Since info is still extant after this call, if you delete fields you should
NULL
> them out. This makes bugs where something accesses them incorrectly easier to
> find.

Done.

http://codereview.chromium.org/652187/diff/5021/4007
File load.cc (left):

http://codereview.chromium.org/652187/diff/5021/4007#oldcode139
load.cc:139: }
On 2010/03/05 18:22:33, davemoore wrote:
> Leave this in until the chrome change is landed (not just in the air). Plus
that
> should be a change all by itself so it's more easily unwound if there's a
> problem.

Done.

[DaveMoore, 2010-03-05 20:40:57]

LGTM