Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 652187: Added ConnectToNetwork (Closed)

Created:
10 years, 10 months ago by Charlie Lee
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler, DaveMoore
CC:
chromium-os-reviews_googlegroups.com, Jason Glasgow, Eric Shienbrood
Visibility:
Public.

Description

Added ConnectToNetwork

Patch Set 1 #

Patch Set 2 : added comments and increased version #

Patch Set 3 : Added ConnectToNetwork #

Patch Set 4 : fix tabs #

Patch Set 5 : Redo a lot of the code #

Patch Set 6 : fix bug #

Patch Set 7 : Reworked to use Server.Connect() #

Total comments: 6

Patch Set 8 : make davemoore's changes #

Patch Set 9 : merge in new changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -251 lines) Patch
M chromeos_cros_api.h View 2 3 4 5 6 7 8 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos_network.h View 1 2 3 4 5 6 5 chunks +53 lines, -48 lines 0 comments Download
M chromeos_network.cc View 1 2 3 4 5 6 7 9 chunks +260 lines, -187 lines 0 comments Download
M load.cc View 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M monitor_network.cc View 5 6 2 chunks +16 lines, -10 lines 0 comments Download
M monitor_utils.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Charlie Lee
Dave, due to the likely breakage of libcros, I will wait until R5 is out ...
10 years, 10 months ago (2010-02-24 00:51:11 UTC) #1
Charlie Lee
Sam, can you take a look at the new method I added. I'm not sure ...
10 years, 10 months ago (2010-02-26 23:14:47 UTC) #2
Sam Leffler
LGTM
10 years, 10 months ago (2010-02-26 23:20:24 UTC) #3
Charlie Lee
Here's the new libcros work that will use Service.Connect() to connect to networks. I went ...
10 years, 9 months ago (2010-03-05 02:09:47 UTC) #4
DaveMoore
http://codereview.chromium.org/652187/diff/5021/4004 File chromeos_cros_api.h (left): http://codereview.chromium.org/652187/diff/5021/4004#oldcode69 chromeos_cros_api.h:69: This is dependent on Chrome not calling the old ...
10 years, 9 months ago (2010-03-05 18:22:33 UTC) #5
Charlie Lee
http://codereview.chromium.org/652187/diff/5021/4004 File chromeos_cros_api.h (left): http://codereview.chromium.org/652187/diff/5021/4004#oldcode69 chromeos_cros_api.h:69: On 2010/03/05 18:22:33, davemoore wrote: > This is dependent ...
10 years, 9 months ago (2010-03-05 20:02:04 UTC) #6
DaveMoore
10 years, 9 months ago (2010-03-05 20:40:57 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698