Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 661224: Stop infinite restarting (Closed)

Created:
10 years, 10 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Stop infinite restarting Dumb logic to stop infinite restarting of the child job (chrome). Now, if we ever try to start the child twice in one second, we decide to (instead) tear everything down and exit the session manager. This should lead to whole UI getting restarted. Eventually, we'd like to do something smarter where we try N times in M seconds, or do an exponential backoff or something. but for now, this keeps users from getting into an infinite loop of starting/crashing chrome.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -7 lines) Patch
M child_job.h View 4 chunks +10 lines, -0 lines 0 comments Download
M child_job.cc View 3 chunks +11 lines, -1 line 1 comment Download
M child_job_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M mock_child_job.h View 1 chunk +7 lines, -5 lines 0 comments Download
M session_manager_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M session_manager_service.cc View 2 chunks +2 lines, -1 line 0 comments Download
M session_manager_setup.sh View 1 chunk +1 line, -0 lines 0 comments Download
M session_manager_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Masone
10 years, 10 months ago (2010-02-26 23:55:04 UTC) #1
DaveMoore
10 years, 10 months ago (2010-02-27 00:56:17 UTC) #2
LGTM, modulo nits

http://codereview.chromium.org/661224/diff/1/2
File child_job.cc (right):

http://codereview.chromium.org/661224/diff/1/2#newcode117
child_job.cc:117: return (time(NULL) - last_start_ < 1);
Nit: could you make this a constant?

Powered by Google App Engine
This is Rietveld 408576698