Stop infinite restarting

child_job.cc

 // Copyright (c) 2009-2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class is most definitely NOT re-entrant.
 
 #include "login_manager/child_job.h"
 
 #include <errno.h>
 #include <grp.h>
 #include <pwd.h>
 #include <signal.h>
 #include <stdlib.h>
+#include <time.h>
 #include <unistd.h>
 
 #include <base/basictypes.h>
 #include <base/command_line.h>
 #include <base/logging.h>
 #include <base/string_util.h>
 
 namespace login_manager {
 // static
 const char SetUidExecJob::kLoginManagerFlag[] = "--login-manager";
 
 // static
 const int SetUidExecJob::kCantSetuid = 127;
 const int SetUidExecJob::kCantSetgid = 128;
 const int SetUidExecJob::kCantSetgroups = 129;
 const int SetUidExecJob::kCantExec = 255;
 
 SetUidExecJob::SetUidExecJob(const CommandLine* command_line,
                              FileChecker* checker,  // Takes ownership.
                              const bool add_flag)
       : checker_(checker),
         argv_(NULL),
         num_args_passed_in_(0),
         desired_uid_(0),
         include_login_flag_(add_flag),
-        set_uid_(false) {
+        set_uid_(false),
+        last_start_(0) {
     PopulateArgv(command_line);
   }
 
 SetUidExecJob::~SetUidExecJob() {
   if (argv_) {
     // free the strings we copied from the passed-in args.
     for (uint32 i = 0; i < num_args_passed_in_; i++) {
       if (argv_[i])
         delete [] argv_[i];
     }
@@ skipping 54 matching lines @@
   }
   if (setsid() == -1)
     LOG(ERROR) << "can't setsid: " << strerror(errno);
   return to_return;
 }
 
 bool SetUidExecJob::ShouldRun() {
   return !checker_->exists();
 }
 
+bool SetUidExecJob::ShouldStop() {
+  return (time(NULL) - last_start_ < 1);

[DaveMoore, 2010/02/27 00:56:17]

Nit: could you make this a constant?

+}
+
+void SetUidExecJob::RecordTime() {
+  time(&last_start_);
+}
+
 void SetUidExecJob::Run() {
   UseLoginManagerFlagIfNeeded();
   // We try to set our UID/GID to the desired UID, and then exec
   // the command passed in.
   int exit_code = SetIDs();
   if (exit_code)
     exit(exit_code);
 
   execv(argv_[0], const_cast<char * const*>(argv_));
 
   // Should never get here, unless we couldn't exec the command.
   LOG(ERROR) << strerror(errno);
   exit(kCantExec);
 }
 
 }  // namespace login_manager