Issue 661205: Make IsStringUTF8 reject (U+FDD0 .. U+FDEF) ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661205: Make IsStringUTF8 reject (U+FDD0 .. U+FDEF) ... (Closed)

Created:
10 years, 10 months ago by jschuh

Modified:
9 years, 6 months ago

Reviewers:
Chris Evans

CC:
chromium-reviews, brettw+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make IsStringUTF8 reject (U+FDD0 .. U+FDEF) Eliminated the old Mozilla implementation and used an ICU-based implementation. BUG=2759 TEST=base_unittests --gtest_filter=StringUtilTest.IsStringUTF8 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40178

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -147 lines)			Patch
M	base/i18n/icu_string_conversions.cc	View	1 2	1 chunk	+0 lines, -9 lines	0 comments	Download
M	base/string_util.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/string_util.cc	View	1 2	2 chunks	+11 lines, -131 lines	0 comments	Download
M	base/string_util_unittest.cc	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download
M	base/utf_string_conversion_utils.h	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jschuh

Windows buildbot is currently flaky, but the unit tests are running clean.

10 years, 10 months ago (2010-02-26 23:28:35 UTC) #1

cevans

10 years, 10 months ago (2010-02-26 23:38:29 UTC) #2

LGTM

On Fri, Feb 26, 2010 at 3:28 PM, <jschuh@chromium.org> wrote:

> Reviewers: Chris Evans,
>
> Message:
> Windows buildbot is currently flaky, but the unit tests are running clean.
>
> Description:
> Make IsStringUTF8 reject (U+FDD0 .. U+FDEF)
>
> Eliminated the old Mozilla implementation and used an ICU-based
> implementation.
>
> BUG=2759
> TEST=base_unittests --gtest_filter=StringUtilTest.IsStringUTF8
>
>
> Please review this at http://codereview.chromium.org/661205
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     base/i18n/icu_string_conversions.cc
>  M     base/string_util.h
>  M     base/string_util.cc
>  M     base/string_util_unittest.cc
>  M     base/utf_string_conversion_utils.h
>
>
>

Expand Messages | Collapse Messages