Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Issue 661164: Revert 39998 - Revert 39996 Refine IPv6 probe to require that the client has... (Closed)

Created:
10 years, 10 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 39998 - Revert 39996 Refine IPv6 probe to require that the client has an IPv6 address on an interface This is a second attempt to land a reviewed change. It was reverted because the tree got very red (for other reasons), and it was plausible that this change was causing startup latency in Mac and Linux (causing both perf bots to go red). If this landing turns those perf-bots red (tonight) I'll need to revert. (... and I'll need to rearchitect to do the probes asynchronously, and get off the startup-critical-path. This currently only works on Posix, not windows. Network changes are monitored, and the test is repeated each time interfaces change (which is a subset of any IP addresses changing). The test performed is still relatively low latency, and we *may* need to eventually move to an high latency test, such as a DNS resolution, or an actual test connection. If we move in that direction, then we'll need to post a task to perform the work, rather than immediately returning. BUG=25680 BUG=12754 r=wtc,eroman Review URL: http://codereview.chromium.org/652072 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/660073 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -48 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +32 lines, -27 lines 0 comments Download
M net/base/host_resolver.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_resolver_impl.h View 2 chunks +11 lines, -3 lines 0 comments Download
M net/base/host_resolver_impl.cc View 4 chunks +22 lines, -1 line 0 comments Download
M net/base/net_util.cc View 5 chunks +54 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jar (doing other things)
10 years, 10 months ago (2010-02-26 05:28:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698