Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 660073: Revert 39996 - Refine IPv6 probe to require that the client has an IPv6 addre... (Closed)

Created:
10 years, 10 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 39996 - Refine IPv6 probe to require that the client has an IPv6 address on an interface This currently only works on Posix, not windows. Network changes are monitored, and the test is repeated each time interfaces change (which is a subset of any IP addresses changing). The test performed is still relatively low latency, and we *may* need to eventually move to an high latency test, such as a DNS resolution, or an actual test connection. If we move in that direction, then we'll need to post a task to perform the work, rather than immediately returning. BUG=25680 BUG=12754 r=wtc,eroman Review URL: http://codereview.chromium.org/652072 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39998

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -120 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +27 lines, -32 lines 1 comment Download
M net/base/host_resolver.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_resolver_impl.h View 2 chunks +3 lines, -11 lines 0 comments Download
M net/base/host_resolver_impl.cc View 4 chunks +1 line, -22 lines 0 comments Download
M net/base/net_util.cc View 5 chunks +16 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jar (doing other things)
10 years, 10 months ago (2010-02-25 07:40:20 UTC) #1
eroman
why the revert?
10 years, 10 months ago (2010-02-25 09:49:55 UTC) #2
jar (doing other things)
There was a regression in startup perf on Mac and Linux. It was conceivable that ...
10 years, 10 months ago (2010-02-25 14:41:48 UTC) #3
wtc
10 years, 10 months ago (2010-02-25 21:41:10 UTC) #4
http://codereview.chromium.org/660073/diff/1/6
File chrome/browser/io_thread.cc (right):

http://codereview.chromium.org/660073/diff/1/6#newcode48
chrome/browser/io_thread.cc:48: if ((!net::IPv6Supported() && use_ipv6_probe) ||
Perhaps we should wait until the first hostname resolution
to call net::IPv6Supported()?

Powered by Google App Engine
This is Rietveld 408576698