Only load text fields in the form structure. This prevents us from trying to...

Only load text fields in the form structure.  This prevents us from trying to autofill username/password forms.

BUG=none
TEST=FormStructureTest
TEST=log in to gmail.  AutoFill infobar should not show up.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39985

[darin (slow to review), 2010-02-24 23:48:55]

Is there a way to write a test for this? :-)

http://codereview.chromium.org/661026/diff/1/2
File chrome/browser/autofill/form_structure.cc (right):

http://codereview.chromium.org/661026/diff/1/2#newcode68
chrome/browser/autofill/form_structure.cc:68: if (field->form_control_type() !=
ASCIIToUTF16(kControlTypeText))
This looks like a good use case for EqualsASCII or perhaps even
LowerCaseEqualsASCII if you are not cetain that form_control_type is
canonicalized to lowercase characters.

[James Hawkins, 2010-02-25 01:15:34]

Also added unit tests for FormStructure.

http://codereview.chromium.org/661026/diff/1/2
File chrome/browser/autofill/form_structure.cc (right):

http://codereview.chromium.org/661026/diff/1/2#newcode68
chrome/browser/autofill/form_structure.cc:68: if (field->form_control_type() !=
ASCIIToUTF16(kControlTypeText))
On 2010/02/24 23:48:55, darin wrote:
> This looks like a good use case for EqualsASCII or perhaps even
> LowerCaseEqualsASCII if you are not cetain that form_control_type is
> canonicalized to lowercase characters.

Done.

[darin (slow to review), 2010-02-25 03:07:55]

LGTM!