Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4299)

Unified Diff: chrome/browser/autofill/form_structure.cc

Issue 661026: Only load text fields in the form structure. This prevents us from trying to... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autofill/form_structure_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/form_structure.cc
===================================================================
--- chrome/browser/autofill/form_structure.cc (revision 39924)
+++ chrome/browser/autofill/form_structure.cc (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -16,10 +16,11 @@
#include "webkit/glue/form_field.h"
#include "webkit/glue/form_field_values.h"
-const char* kFormMethodGet = "get";
+namespace {
+
const char* kFormMethodPost = "post";
-// XML attribute names
+// XML attribute names.
const char* const kAttributeClientVersion = "clientversion";
const char* const kAttributeAutoFillUsed = "autofillused";
const char* const kAttributeSignature = "signature";
@@ -30,8 +31,12 @@
const char* const kXMLElementField = "field";
const char* const kAttributeAutoFillType = "autofilltype";
-namespace {
+// The only form control type we handle currently.
+const char* const kControlTypeText = "text";
+// The number of fillable fields necessary for a form to be fillable.
+const size_t kRequiredFillableFields = 3;
+
static std::string Hash64Bit(const std::string& str) {
std::string hash_bin = base::SHA1HashString(str);
DCHECK_EQ(20U, hash_bin.length());
@@ -58,6 +63,11 @@
std::vector<webkit_glue::FormField>::const_iterator field;
for (field = values.elements.begin();
field != values.elements.end(); field++) {
+ // We currently only handle text fields. This prevents us from thinking we
+ // can autofill other types of controls, e.g., select, password, hidden.
+ if (!LowerCaseEqualsASCII(field->form_control_type(), kControlTypeText))
+ continue;
+
// Generate a unique name for this field by appending a counter to the name.
string16 unique_name = field->name() + IntToString16(fields_.size() + 1);
fields_.push_back(new AutoFillField(*field, unique_name));
@@ -165,7 +175,7 @@
}
bool FormStructure::IsAutoFillable() const {
- if (field_count() == 0)
+ if (field_count() < kRequiredFillableFields)
return false;
// Rule out http(s)://*/search?...
@@ -174,13 +184,6 @@
if (target_url_.path() == "/search")
return false;
- // Disqualify all forms that are likely to be search boxes (like google.com).
- if (field_count() == 1) {
- std::string name = UTF16ToUTF8(fields_[0]->name());
- if (name == "q")
- return false;
- }
-
if (method_ == GET)
return false;
« no previous file with comments | « no previous file | chrome/browser/autofill/form_structure_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698