chrome/common/extensions/update_manifest.cc - Issue 6609008: Change other usages of .size() to .empty() when applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/update_manifest.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter nits Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/update_manifest.cc

diff --git a/chrome/common/extensions/update_manifest.cc b/chrome/common/extensions/update_manifest.cc

index 4e1cdd54bcf9a8f405270114ef61fe201cf79f10..8970aa5d3ae8f79b2ee5794522560505f16077b9 100644

--- a/chrome/common/extensions/update_manifest.cc

+++ b/chrome/common/extensions/update_manifest.cc

@@ -242,7 +242,7 @@ bool UpdateManifest::Parse(const std::string& manifest_xml) {

// Parse the first <daystart> if it's present.

std::vector<xmlNode*> daystarts = GetChildren(root, gupdate_ns, "daystart");

- if (daystarts.size() > 0) {

+ if (!daystarts.empty()) {

xmlNode* first = daystarts[0];

std::string elapsed_seconds = GetAttribute(first, "elapsed_seconds");

int parsed_elapsed = kNoDaystart;