Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 6609003: Remove NAND support from the common tegra2 configuration. (Closed)

Created:
9 years, 9 months ago by robotboy
Modified:
9 years, 7 months ago
Reviewers:
vb, sjg, Che-Liang Chiou
CC:
chromium-os-reviews_chromium.org, dneiss, Olof Johansson, robotboy, chromeboy, amoljadi
Visibility:
Public.

Description

Remove NAND support from the common tegra2 configuration. Not all of our boards have NAND, and we are not using NAND commands currently. BUG=chromium-os:11981 TEST=build and boot U-Boot on Kaen. Change-Id: I02336d0fc530b0ac41e35f2903ae67623b32874c Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e1758d4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M include/configs/chromeos/tegra2/common.h View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
robotboy
9 years, 9 months ago (2011-03-03 00:14:51 UTC) #1
vb
LGTM with a comment to your discretion: http://codereview.chromium.org/6609003/diff/1/include/configs/chromeos/tegra2/common.h File include/configs/chromeos/tegra2/common.h (left): http://codereview.chromium.org/6609003/diff/1/include/configs/chromeos/tegra2/common.h#oldcode132 include/configs/chromeos/tegra2/common.h:132: #include <configs/chromeos/tegra2/parts/nand.h> ...
9 years, 9 months ago (2011-03-03 03:44:03 UTC) #2
robotboy
9 years, 9 months ago (2011-03-03 03:49:51 UTC) #3
It could be.  But nothing uses it right now, so we can add it back when we
need it.

-Anton

On Wed, Mar 2, 2011 at 7:44 PM, <vbendeb@chromium.org> wrote:

> LGTM
>
> with a comment to your discretion:
>
>
>
>
http://codereview.chromium.org/6609003/diff/1/include/configs/chromeos/tegra2...
> File include/configs/chromeos/tegra2/common.h (left):
>
>
>
http://codereview.chromium.org/6609003/diff/1/include/configs/chromeos/tegra2...
> include/configs/chromeos/tegra2/common.h:132: #include
>
> <configs/chromeos/tegra2/parts/nand.h>
> should it be added to some other image(set of images) instead? How about
> developer image?
>
>
> http://codereview.chromium.org/6609003/
>

Powered by Google App Engine
This is Rietveld 408576698