Issue 6606011: Switch to using cros_sign_bootstub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6606011: Switch to using cros_sign_bootstub. (Closed)

Created:
9 years, 9 months ago by robotboy

Modified:
9 years, 7 months ago

Reviewers:
sjg, vb, Che-Liang Chiou

CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, adlr+crosoverlay_chromium.org, anush

Base URL:
ssh://git@gitrw.chromium.org:9222/chromiumos-overlay.git@master

Visibility:
Public.

Description

Switch to using cros_sign_bootstub. This installs the new cros_sign_bootstub utility into the chroot as a host tool and uses it in the chromeos-bios ebuild. The cros_sign_bootstub tool was introduced in: http://codereview.chromium.org/6592053/ BUG=chromium-os:11981 TEST=build and boot U-Boot/kernel/ChromiumOS on Kaen. Change-Id: If56ec41edb01c22ff4b52634222b5ea3c78d6a33 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ed5c241

Patch Set 1 #

Patch Set 2 : Don't install boot.cfg, it's no longer generated. #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -35 lines)			Patch
	M	chromeos-base/cros-devutils/cros-devutils-9999.ebuild	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	sys-boot/chromeos-bios/chromeos-bios-0.0.1.ebuild	View	1	3 chunks	+7 lines, -35 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

9 years, 9 months ago (2011-03-03 04:10:19 UTC) #2

LGTM

with comments below:

In the CL desription
s/cros_sign_bootloader/cros_sign_bootstub/
(or am I missing something?)

http://codereview.chromium.org/6606011/diff/3001/sys-boot/chromeos-bios/chrom...
File sys-boot/chromeos-bios/chromeos-bios-0.0.1.ebuild (right):

http://codereview.chromium.org/6606011/diff/3001/sys-boot/chromeos-bios/chrom...
sys-boot/chromeos-bios/chromeos-bios-0.0.1.ebuild:94: cros_sign_bootstub \
please add to the CL description some information as of where cros_sign_bootstub
comes from (maybe a link to the CL which introduced it).

Hopefully that CL has some information about what this utility does and what
parameters it expects, at the very least it's text would be available.

Expand Messages | Collapse Messages