Build pyauto only if the architecture of python binary matches....

Build pyauto only if the architecture of python binary matches.

BUG=none
TEST=Building 32-bit pyauto on 64-bit Linux with a 32-bit sysroot works.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40630

[Nirnimesh, 2010-03-03 18:30:29]

Linux trybot result appears broken. Please re-try.

LGTM after green.

On Tue, Mar 2, 2010 at 10:32 PM, <thestig@chromium.org> wrote:

> Reviewers: zel, Nirnimesh,
>
> Description:
> Build pyauto only if the architecture of python binary matches.
>
> BUG=none
> TEST=Building 32-bit pyauto on 64-bit Linux with a 32-bit sysroot works.
>
> Please review this at http://codereview.chromium.org/660443
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     build/common.gypi
>  A     build/linux/python_arch.sh
>  M     chrome/chrome_tests.gypi
>
>
>


-- 
../NiR

[Lei Zhang, 2010-03-03 18:33:25]

That's because patch doesn't know to apply the svn executable bit for the shells
script.

On 2010/03/03 18:30:29, Nirnimesh wrote:
> Linux trybot result appears broken. Please re-try.
> 
> LGTM after green.
> 
> On Tue, Mar 2, 2010 at 10:32 PM, <mailto:thestig@chromium.org> wrote:
> 
> > Reviewers: zel, Nirnimesh,
> >
> > Description:
> > Build pyauto only if the architecture of python binary matches.
> >
> > BUG=none
> > TEST=Building 32-bit pyauto on 64-bit Linux with a 32-bit sysroot works.
> >
> > Please review this at http://codereview.chromium.org/660443
> >
> > SVN Base: svn://chrome-svn/chrome/trunk/src/
> >
> > Affected files:
> >  M     build/common.gypi
> >  A     build/linux/python_arch.sh
> >  M     chrome/chrome_tests.gypi
> >
> >
> >
> 
> 
> -- 
> ../NiR
>

[zel, 2010-03-03 18:45:23]

LGTM

[Nirnimesh, 2010-03-03 22:14:36]

LGTM (in case you were waiting on me)