Issue 6602023: Revert 76324 - Build WebKit Full Screen API. Support is disabled by default; ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6602023: Revert 76324 - Build WebKit Full Screen API. Support is disabled by default; ... (Closed)

Created:
9 years, 9 months ago by jamesr

Modified:
9 years, 6 months ago

Reviewers:
ddorwin

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 76324 - Build WebKit Full Screen API. Support is disabled by default; enable with --enable-fullscreen. Commit after WK bug 44797 (r79774). BUG=16735 TEST=fullscreen layout tests. Review URL: http://codereview.chromium.org/6576004 TBR=ddorwin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76335

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -16 lines)			Patch
M	build/features_override.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/render_messages.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/glue/webpreferences.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jamesr

9 years, 9 months ago (2011-03-01 01:24:09 UTC) #2

I had to revert the WebKit roll that pulled in r79774 (due to failures unrelated
to fullscreen), so I had to revert this as well.  Once WebKit rolls forward
again past r79774, this can re-land.

Expand Messages | Collapse Messages