Issue 6576004: Build WebKit Full Screen API. Support is disabled by default; enable with --enable-fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6576004: Build WebKit Full Screen API. Support is disabled by default; enable with --enable-fullscreen. (Closed)

Created:
9 years, 10 months ago by ddorwin

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Build WebKit Full Screen API. Support is disabled by default; enable with --enable-fullscreen. Commit after WK bug 44797 (r79774). BUG=16735 TEST=fullscreen layout tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76324

Patch Set 1 #

Patch Set 2 : Removed extra space. #

Total comments: 1

Patch Set 3 : Fixed nit and synced. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
M	build/features_override.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/glue/webpreferences.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

9 years, 10 months ago (2011-02-25 01:33:50 UTC) #2

LGTM w/ one nit

http://codereview.chromium.org/6576004/diff/2001/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/6576004/diff/2001/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:518: // Enable the JavaaScript Full Screen API.
JavaaScript -> JavaScript

Expand Messages | Collapse Messages