Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 6602012: Adds method to invoke platform provided audio input UI. (Closed)

Created:
9 years, 9 months ago by Satish
Modified:
9 years, 7 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM)
Visibility:
Public.

Description

Adds method to invoke platform provided audio input UI. This will be used in a future CL by the speech input feature. BUG=69886 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76363

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M media/audio/audio_manager.h View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M media/audio/audio_manager_base.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M media/audio/audio_manager_base.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/linux/audio_manager_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/linux/audio_manager_linux.cc View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M media/audio/win/audio_manager_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/win/audio_manager_win.cc View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Satish
9 years, 9 months ago (2011-02-28 19:07:59 UTC) #1
Alpha Left Google
In general AudioManager is accessed on IO thread, however the way we show the audio ...
9 years, 9 months ago (2011-02-28 19:12:06 UTC) #2
Satish
Thanks. As discussed I have added a comment about this and will make sure the ...
9 years, 9 months ago (2011-02-28 19:43:20 UTC) #3
scherkus (not reviewing)
I also share concerns over launching processes... I'm not familiar with the process launcher thread, ...
9 years, 9 months ago (2011-02-28 21:18:13 UTC) #4
Satish
> I'm not familiar with the process launcher thread, but is it possible to have ...
9 years, 9 months ago (2011-02-28 21:30:44 UTC) #5
scherkus (not reviewing)
9 years, 9 months ago (2011-02-28 21:38:48 UTC) #6
On 2011/02/28 21:30:44, Satish wrote:
> > I'm not familiar with the process launcher thread, but is it possible to
have
> > the callee use post a task to call ShowAudioInputSettings?
> > 
> > if so then I think we're OK -- there's no need to introduce that dependency
> here
> > since different applications (like under media/tools) don't necessarily need
> to
> > worry about threading restrictions :)
> 
> Yes that is the idea, but the callee can't directly ask PostTask to invoke
> ShowAudioInputSettings since this class isn't refcounted. However I can make
> ShowAudioInputSettings() a static function which would simplify for the
callees.
> Thoughts?

Since AudioManager is (roughly!) a singleton it might make sense to disable
ref-counting for tasks.  See base/task.h

DISABLE_RUNNABLE_METHOD_REFCOUNT(media::AudioManager);

OR we split the settings stuff into a whole separate class but that seems
overkill

Powered by Google App Engine
This is Rietveld 408576698