Chromium Code Reviews

Issue 660174: Return length passed instead of receiver to allow chained assignments like (Closed)

Created:
10 years, 10 months ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
Søren Thygesen Gjesse
CC:
v8-dev
Visibility:
Public.

Description

Return length passed instead of receiver to allow chained assignments like foo = a.length = 7 BUG=crbug.com/36854 Committed: http://code.google.com/p/v8/source/detail?r=3979

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+19 lines, -7 lines)
M src/ic.cc View 1 chunk +3 lines, -1 line 0 comments
M test/mjsunit/array-length.js View 6 chunks +16 lines, -6 lines 0 comments

Messages

Total messages: 2 (0 generated)
antonm
Søren, Mads, may you have a look? Actual reduction is the last loop added. It ...
10 years, 10 months ago (2010-02-26 13:24:34 UTC) #1
Søren Thygesen Gjesse
10 years, 10 months ago (2010-02-26 14:09:42 UTC) #2
LGTM

Powered by Google App Engine