src/ic.cc - Issue 660174: Return length passed instead of receiver to allow chained assignments like

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 660174: Return length passed instead of receiver to allow chained assignments like (Closed)

Patch Set: Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index 31ece04a0b820beac92c3f3b3a46182628339937..8fd777a362c1997240d850bb4f3d1bc486df9e50 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -1365,7 +1365,9 @@ Object* StoreIC_ArrayLength(Arguments args) {

JSObject* receiver = JSObject::cast(args[0]);

Object* len = args[1];

- return receiver->SetElementsLength(len);

+ Object* result = receiver->SetElementsLength(len);

+ if (result->IsFailure()) return result;

+ return len;

}

« no previous file with comments | « no previous file | test/mjsunit/array-length.js » ('j') | no next file with comments »