Issue 660168: Disable registering, unregistering, and setting default browser...

Issue 660168: Disable registering, unregistering, and setting default browser... (Closed)

Created:
10 years, 10 months ago by huanr

Modified:
9 years ago

Reviewers:
mattm

CC:
chromium-reviews, kuchhal, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable registering, unregistering, and setting default browser for sxs install. BUG=35574 TEST="setup.exe --chrome-sxs" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40203

Patch Set 5 : '' #

Total comments: 2

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -11 lines)			Patch
M	chrome/browser/browser_init.cc	View	1 2 3 4	2 chunks	+5 lines, -0 lines	2 comments	Download
M	chrome/installer/setup/setup_main.cc	View	2	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/installer/setup/uninstall.cc	View	1 2	2 chunks	+14 lines, -6 lines	0 comments	Download
M	chrome/installer/util/browser_distribution.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/installer/util/browser_distribution.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/installer/util/google_chrome_sxs_distribution.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/util/google_chrome_sxs_distribution.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/installer/util/shell_util.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mattm

lgtm http://codereview.chromium.org/660168/diff/38/1046 File chrome/browser/browser_init.cc (right): http://codereview.chromium.org/660168/diff/38/1046#newcode199 chrome/browser/browser_init.cc:199: return; could do this check before the IsDefaultBrowser ...

10 years, 10 months ago (2010-02-26 23:53:49 UTC) #2

huanr

http://codereview.chromium.org/660168/diff/38/1046 File chrome/browser/browser_init.cc (right): http://codereview.chromium.org/660168/diff/38/1046#newcode199 chrome/browser/browser_init.cc:199: return; On 2010/02/26 23:53:50, mattm wrote: > could do ...

10 years, 10 months ago (2010-02-27 00:02:34 UTC) #3

mattm

10 years, 10 months ago (2010-02-27 00:25:40 UTC) #4

True.  I could say calling a function that just returns true or false
isn't that big a deal for the more common case to do, but you can
leave it as this.

On Fri, Feb 26, 2010 at 16:02,  <huanr@chromium.org> wrote:
>
> http://codereview.chromium.org/660168/diff/38/1046
> File chrome/browser/browser_init.cc (right):
>
> http://codereview.chromium.org/660168/diff/38/1046#newcode199
> chrome/browser/browser_init.cc:199: return;
> On 2010/02/26 23:53:50, mattm wrote:
>>
>> could do this check before the IsDefaultBrowser call (not a huge deal,
>
> but I
>>
>> recall IsDefaultBrowser being slightly expensive)
>
> However we should optimize for the more common case, non-sxs default
> browser.
>
> http://codereview.chromium.org/660168
>

Expand Messages | Collapse Messages