Log a warning message if an SSL server does not support...

Log an informational message if an SSL server does not support
SSL secure renegotiation.

R=abarth
BUG=none
TEST=Run Chrome witl logging enabled.  Visit https://www.google.com/.
An informational message like
  [1812:8012:351987676:INFO:ssl_client_socket_nss.cc(651)]
  The server www.google.com does not support SSL secure renegotiation.
should be logged.  Then visit https://ssltls.de/.  No such informational
message should be logged.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40192

[abarth-chromium, 2010-02-26 01:06:36]

Ok, but don't we want to log this to the developer console?

[wtc, 2010-02-26 01:23:01]

On 2010/02/26 01:06:36, abarth wrote:
> Ok, but don't we want to log this to the developer console?

How do I log something to the developer console?

Does the net module have access to the developer console?
If not, I will need to add this bit of info to the SSLInfo
structure.

[abarth-chromium, 2010-02-26 02:22:21]

I don't think net can do that directly.  I'm not sure how much plumbing
would be needed.

On Feb 25, 2010 5:23 PM, <wtc@chromium.org> wrote:

On 2010/02/26 01:06:36, abarth wrote:
>
> Ok, but don't we want to log this to the developer console...
How do I log something to the developer console?

Does the net module have access to the developer console?
If not, I will need to add this bit of info to the SSLInfo
structure.



http://codereview.chromium.org/660144

[wtc, 2010-02-26 03:11:40]

I also found that RenderViewHost::AddMessageToConsole doesn't
seem to be used.

Can I just use LOG(XXX)?  I think I should lower the logging
level to INFO for now.

[wtc, 2010-02-26 04:20:30]

OK, Patch Set 2 logs warning messages to the Console
in "Inspect element".

It still needs polishing, but all the plumbing is done.

I am using the |cert_status| field to convey the fact that
the server doesn't support secure renegotiation.  That fact
has nothing to do with certificates, so I am a little worried
that this could cause confusion in the future.  But
it's convenient to just use |cert_status|.

Adam, what do you think?  I have to say the
"Inspect element" Console is not very discoverable,
whereas many Chrome users on Linux seem to discover our
logging messages easily.

[wtc, 2010-02-26 04:27:09]

I found one problem with logging to the Console: if the
page is redirected, the warning message for the original
URL is gone.

So I'm now in favor of just logging to the debug log.

[abarth-chromium, 2010-02-26 04:45:38]

> So I'm now in favor of just logging to the debug log.

Ok.  If you think that's better, let's go with that.

[wtc, 2010-02-26 19:59:42]

At some point we'll need to plumb the fact that a server
doesn't support secure renegotiation to the SSLManager or
SSLPolicy so that it can be shown in Page Security
Information dialog.  But I don't want to add that bit to
cert_status to avoid confusion.  I think I'll need to add
a connection_status member to net::SSLInfo and
NavigationEntry::SSLStatus and put the bit flag in
connection_status.  I'll do that when the time comes.

For now, I'll just log an informational message.  The
default logging level is "warning", so most people won't
see these messages.  Sigh.