Issue 660142: Add resilience in croc to a failed build (e.g. 0 stats generated)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660142: Add resilience in croc to a failed build (e.g. 0 stats generated).... (Closed)

Created:
10 years, 9 months ago by John Grabowski

Modified:
9 years, 5 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, pam+watch_chromium.org, James Hawkins

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add resilience in croc to a failed build (e.g. 0 stats generated). Makes a failure case suck less. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40138

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
	M	tools/code_coverage/croc.py	View	1 2	3 chunks	+21 lines, -0 lines	0 comments	Download
	M	tools/code_coverage/croc_test.py	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

Doesn't fix the problem but makes us more resilient to it. (I also did an ...

10 years, 9 months ago (2010-02-26 00:40:09 UTC) #1

John Grabowski

10 years, 9 months ago (2010-02-26 00:46:36 UTC) #3

For the record, here is a sample error:
http://build.chromium.org/buildbot/waterfall.fyi/builders/Linux%20Coverage%20...

<http://build.chromium.org/buildbot/waterfall.fyi/builders/Linux%20Coverage%20...>

On Thu, Feb 25, 2010 at 4:45 PM, <estade@chromium.org> wrote:

> lgtm
>
>
> http://codereview.chromium.org/660142
>

Expand Messages | Collapse Messages