Inlining a few virtual frame functions....

Inlining a few virtual frame functions.

Introducing a virtual-frame-inl.h file containing some platform-independent
virtual frame function which are small enough to be inlined.

Removed unnecessary #include of virtual-frame.h from register-allocator-inl.h
and added the necessary explicit includes in a number of files.


Committed: http://code.google.com/p/v8/source/detail?r=3962

[fschneider, 2010-02-26 09:03:17]

It looks a lot, but is really only refactoring, cleanup of includes and
declaring some small functions in the virtual frame and the code generator as
inline.

[Søren Thygesen Gjesse, 2010-02-26 09:14:29]

LGTM

http://codereview.chromium.org/660104/diff/26/1052
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/660104/diff/26/1052#newcode349
src/arm/virtual-frame-arm.h:349: void Push(Smi* value) {
Push(Handle<Object>(value)); }
Should this be inline as well (all three platforms)?

[fschneider, 2010-02-26 10:41:08]

http://codereview.chromium.org/660104/diff/26/1052
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/660104/diff/26/1052#newcode349
src/arm/virtual-frame-arm.h:349: void Push(Smi* value) {
Push(Handle<Object>(value)); }
On 2010/02/26 09:14:29, Søren Gjesse wrote:
> Should this be inline as well (all three platforms)?

Done. It should be inlined already since it is defined in the .h file, but to be
consistent I moved it also to the -inl.h file.